GNU bug report logs - #73878
[PATCH] gnu: services: Fix readymedia service.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Fabio Natali <me <at> fabionatali.com>
Subject: bug#73878: closed (Re: [PATCH] gnu: services: Fix readymedia
 service.)
Date: Sun, 20 Oct 2024 11:30:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73878: [PATCH] gnu: services: Fix readymedia service.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73878 <at> debbugs.gnu.org.

-- 
73878: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73878
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 73878-done <at> debbugs.gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: Re: [PATCH] gnu: services: Fix readymedia service.
Date: Sun, 20 Oct 2024 12:28:38 +0100

Pushed, thanks! I also fixed a couple of minor errors in cf33081e18 and
9b835aae10

[Message part 3 (message/rfc822, inline)]

From: Fabio Natali <me <at> fabionatali.com>
To: guix-patches <at> gnu.org
Cc: arunisaac <at> systemreboot.net, Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: services: Fix readymedia service.
Date: Sat, 19 Oct 2024 13:11:43 +0100

* gnu/services/upnp.scm: Add missing '/n' end-of-line character.

Change-Id: Ib2e584f22526f1969098b843c4be6ee386ed809c
---
Hi,

This is to fix 'readymedia-configuration->config-file'.

In its current version, the procedure may generate a corrupt configuration file.
This patch fixes things by adding a new line character at the end of every
'media_dir=' line.

I hope this looks ok.

Thanks, best wishes, Fabio.

 gnu/services/upnp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm
index 09121326fe..e5d05add28 100644
--- a/gnu/services/upnp.scm
+++ b/gnu/services/upnp.scm
@@ -115,7 +115,7 @@ (define (readymedia-configuration->config-file config)
                                          (match types
                                            (() (list))
                                            (_ (list ",")))
-                                         (list path))))
+                                         (list path "\n"))))
                         media-directories)
                    (map (match-lambda
                           ((key . value)

base-commit: 48097f511929053468ce6f09e0a24644c90fe670
-- 
2.46.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.