GNU bug report logs - #73878
[PATCH] gnu: services: Fix readymedia service.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73878 in the body.
You can then email your comments to 73878 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: guix-patches <at> gnu.org
Cc: arunisaac <at> systemreboot.net, Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: services: Fix readymedia service.
Date: Sat, 19 Oct 2024 13:11:43 +0100

* gnu/services/upnp.scm: Add missing '/n' end-of-line character.

Change-Id: Ib2e584f22526f1969098b843c4be6ee386ed809c
---
Hi,

This is to fix 'readymedia-configuration->config-file'.

In its current version, the procedure may generate a corrupt configuration file.
This patch fixes things by adding a new line character at the end of every
'media_dir=' line.

I hope this looks ok.

Thanks, best wishes, Fabio.

 gnu/services/upnp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm
index 09121326fe..e5d05add28 100644
--- a/gnu/services/upnp.scm
+++ b/gnu/services/upnp.scm
@@ -115,7 +115,7 @@ (define (readymedia-configuration->config-file config)
                                          (match types
                                            (() (list))
                                            (_ (list ",")))
-                                         (list path))))
+                                         (list path "\n"))))
                         media-directories)
                    (map (match-lambda
                           ((key . value)

base-commit: 48097f511929053468ce6f09e0a24644c90fe670
-- 
2.46.0

Message #8 received at 73878 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 73878 <at> debbugs.gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: Re: [PATCH] gnu: services: Fix readymedia service.
Date: Sun, 20 Oct 2024 01:53:24 +0100

Hi Fabio,

Thanks for the patch. I'll push this shortly. My laptop is just busy
building something else at the moment.

Regards,
Arun

Message #13 received at 73878-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 73878-done <at> debbugs.gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: Re: [PATCH] gnu: services: Fix readymedia service.
Date: Sun, 20 Oct 2024 12:28:38 +0100

Pushed, thanks! I also fixed a couple of minor errors in cf33081e18 and
9b835aae10

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.