GNU bug report logs - #73877
30; rust-ts-mode: highlight the possible type suffix of number literals

Previous Next

Full log

View this message in rfc822 format

From: Christophe TROESTLER <Christophe.TROESTLER <at> umons.ac.be>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, "73877 <at> debbugs.gnu.org" <73877 <at> debbugs.gnu.org>, Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals
Date: Mon, 18 Nov 2024 15:14:40 +0000

[Message part 1 (text/plain, inline)]

On 15 November 2024 at 01:11 +01, Randy Taylor <dev <at> rjt.dev> wrote:
> […] the patch didn't apply cleanly for me […]

Here is an updated version of the patch against today's master branch.

> […] If you do the same as treesit-font-lock-level, […]

For some reason it did not work in the past but it does now, so that's how I proceeded.

> You will also need to: (require 'rust-ts-mode)

Ok — some tests do that, others don't, so I did not originally change that.  I've now added the “require”.

> After you make that change, I think you should be able to get rid of
> this:
> +(put 'rust-ts-mode-fontify-number-suffix-as-type 'safe-local-variable
> +     'booleanp)

I first thought that one may want to set that change for specific file but, you are right, it is more of a user choice that should be set in your own config. files.

> In the font-lock-number.rs file, it looks like there is an extraneous
> newline at the top of the file.

Fixed.

> BTW the current patch still doesn't apply against the latest master
> for me.

I have rebased it on the current origin/master.

Best,
C.

[0001-Rust-ts-fontify-as-type-the-possible-suffix-of-numbe.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.