GNU bug report logs - #73877
30; rust-ts-mode: highlight the possible type suffix of number literals

Previous Next

Package: emacs;

Reported by: Christophe TROESTLER <Christophe.TROESTLER <at> umons.ac.be>

Date: Sat, 19 Oct 2024 11:02:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Randy Taylor <dev <at> rjt.dev>
To: Christophe TROESTLER <Christophe.TROESTLER <at> umons.ac.be>
Cc: Eli Zaretskii <eliz <at> gnu.org>, "73877 <at> debbugs.gnu.org" <73877 <at> debbugs.gnu.org>, Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals
Date: Sat, 02 Nov 2024 19:48:18 +0000
On Monday, October 28th, 2024 at 17:56, Christophe TROESTLER <Christophe.TROESTLER <at> umons.ac.be> wrote:
> 
> 
> Hi,
> 
> Here is an updated patch that (hopefully) addresses all of your remarks except the last one

Sorry for the delay.

The patch looks good to me with Eli's points addressed (thanks Eli for
taking a look) and the below addressed.

>...: when executing the tests interactively in the instance of Emacs one works with, it is good IMHO that global variables are not changed under our feet. That being said, it is not a strong opinion and I can remove the reset if you wish.

Unless I am missing something, the variables should reset automatically.
They are only changed in the context of the test.

How are you running them that you are seeing otherwise?

> 
> Best,
> C.
>




This bug report was last modified 175 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.