GNU bug report logs - #73836
[PATCH] gnu: kcolorpicker: Build with -fPIC

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Z572 <zhengjunjie <at> iscas.ac.cn>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73836: closed ([PATCH] gnu: kcolorpicker: Build with -fPIC)
Date: Wed, 16 Oct 2024 11:20:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 16 Oct 2024 19:18:17 +0800
with message-id <87frow47pi.fsf <at> iscas.ac.cn>
and subject line Re: [bug#73836] [PATCH] gnu: kcolorpicker: Build with -fPIC
has caused the debbugs.gnu.org bug report #73836,
regarding [PATCH] gnu: kcolorpicker: Build with -fPIC
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73836: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73836
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Doğan Çeçen <sepeth <at> fastmail.com>
Subject: [PATCH] gnu: kcolorpicker: Build with -fPIC
Date: Wed, 16 Oct 2024 11:12:45 +0200

It fixes linking errors when building kimageannotator:

    ...
    ld:
    /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
    relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
    `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
    not be used when making a shared object; recompile with -fPIC
    ...

* gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
  configure-flags to add -fPIC to CMAKE_CXX_FLAGS.

Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07b861c672..13d4e24726 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -660,7 +660,8 @@ (define-public kcolorpicker
     (build-system qt-build-system)
     (arguments
      (list #:qtbase qtbase
-           #:configure-flags #~(list "-DBUILD_TESTS=ON"
+           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
+                                     "-DBUILD_TESTS=ON"
                                      "-DBUILD_WITH_QT6=ON")))
     (home-page "https://github.com/ksnip/kColorPicker")
     (synopsis "Color Picker with popup menu")

base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Z572 <zhengjunjie <at> iscas.ac.cn>
To: Doğan Çeçen <sepeth <at> fastmail.com>
Cc: 73836-done <at> debbugs.gnu.org
Subject: Re: [bug#73836] [PATCH] gnu: kcolorpicker: Build with -fPIC
Date: Wed, 16 Oct 2024 19:18:17 +0800

[Message part 4 (text/plain, inline)]

Doğan Çeçen <sepeth <at> fastmail.com> writes:

> It fixes linking errors when building kimageannotator:
>
>     ...
>     ld:
>     /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
>     relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
>     `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
>     not be used when making a shared object; recompile with -fPIC
>     ...
>
> * gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
>   configure-flags to add -fPIC to CMAKE_CXX_FLAGS.
>
> Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
> ---
>  gnu/packages/kde-frameworks.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 07b861c672..13d4e24726 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -660,7 +660,8 @@ (define-public kcolorpicker
>      (build-system qt-build-system)
>      (arguments
>       (list #:qtbase qtbase
> -           #:configure-flags #~(list "-DBUILD_TESTS=ON"
> +           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
> +                                     "-DBUILD_TESTS=ON"
>                                       "-DBUILD_WITH_QT6=ON")))
>      (home-page "https://github.com/ksnip/kColorPicker")
>      (synopsis "Color Picker with popup menu")
>
> base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
Thanks, push and close.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.