GNU bug report logs - #73836
[PATCH] gnu: kcolorpicker: Build with -fPIC

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73836 in the body.
You can then email your comments to 73836 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Doğan Çeçen <sepeth <at> fastmail.com>
Subject: [PATCH] gnu: kcolorpicker: Build with -fPIC
Date: Wed, 16 Oct 2024 11:12:45 +0200

It fixes linking errors when building kimageannotator:

    ...
    ld:
    /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
    relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
    `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
    not be used when making a shared object; recompile with -fPIC
    ...

* gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
  configure-flags to add -fPIC to CMAKE_CXX_FLAGS.

Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07b861c672..13d4e24726 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -660,7 +660,8 @@ (define-public kcolorpicker
     (build-system qt-build-system)
     (arguments
      (list #:qtbase qtbase
-           #:configure-flags #~(list "-DBUILD_TESTS=ON"
+           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
+                                     "-DBUILD_TESTS=ON"
                                      "-DBUILD_WITH_QT6=ON")))
     (home-page "https://github.com/ksnip/kColorPicker")
     (synopsis "Color Picker with popup menu")

base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
-- 
2.46.0

Message #10 received at 73836-done <at> debbugs.gnu.org (full text, mbox):

From: Z572 <zhengjunjie <at> iscas.ac.cn>
To: Doğan Çeçen <sepeth <at> fastmail.com>
Cc: 73836-done <at> debbugs.gnu.org
Subject: Re: [bug#73836] [PATCH] gnu: kcolorpicker: Build with -fPIC
Date: Wed, 16 Oct 2024 19:18:17 +0800

[Message part 1 (text/plain, inline)]

Doğan Çeçen <sepeth <at> fastmail.com> writes:

> It fixes linking errors when building kimageannotator:
>
>     ...
>     ld:
>     /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
>     relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
>     `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
>     not be used when making a shared object; recompile with -fPIC
>     ...
>
> * gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
>   configure-flags to add -fPIC to CMAKE_CXX_FLAGS.
>
> Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
> ---
>  gnu/packages/kde-frameworks.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 07b861c672..13d4e24726 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -660,7 +660,8 @@ (define-public kcolorpicker
>      (build-system qt-build-system)
>      (arguments
>       (list #:qtbase qtbase
> -           #:configure-flags #~(list "-DBUILD_TESTS=ON"
> +           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
> +                                     "-DBUILD_TESTS=ON"
>                                       "-DBUILD_WITH_QT6=ON")))
>      (home-page "https://github.com/ksnip/kColorPicker")
>      (synopsis "Color Picker with popup menu")
>
> base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
Thanks, push and close.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.