GNU bug report logs - #73810
[PATCH] services: cuirass: Run ‘remote-worker’ under its own user/group.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#73810: closed (Re: [bug#73810] [PATCH] services: cuirass: Run
 ‘remote-worker’ under its own user/group.)
Date: Sun, 03 Nov 2024 22:17:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#73810: [PATCH] services: cuirass: Run ‘remote-worker’ under its own user/group.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73810 <at> debbugs.gnu.org.

-- 
73810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73810
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: 73810-done <at> debbugs.gnu.org
Subject: Re: [bug#73810] [PATCH] services: cuirass: Run
 ‘remote-worker’ under its own user/group.
Date: Sun, 03 Nov 2024 23:16:29 +0100

Ludovic Courtès <ludo <at> gnu.org> skribis:

> The ‘--user’ option was added to ‘cuirass remote-worker’ in Cuirass
> commit 3a6abc17f904f38098d3ab08e9d82de2e821d348 (Nov. 2023).
>
> * gnu/services/cuirass.scm (%cuirass-remote-worker-accounts): New
> variable.
> (cuirass-remote-worker-shepherd-service): Pass ‘--user’.
> (cuirass-remote-worker-service-type): Add ACCOUNT-SERVICE-TYPE
> extension.
>
> Change-Id: I075ea02b6972adcad0a75e330073e85c4dacbbc5

Pushed as e7a445571d0e45be96894bc6b298b67ceb2f3989.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] services: cuirass: Run ‘remote-worker’ under its own user/group.
Date: Mon, 14 Oct 2024 23:16:02 +0200

The ‘--user’ option was added to ‘cuirass remote-worker’ in Cuirass
commit 3a6abc17f904f38098d3ab08e9d82de2e821d348 (Nov. 2023).

* gnu/services/cuirass.scm (%cuirass-remote-worker-accounts): New
variable.
(cuirass-remote-worker-shepherd-service): Pass ‘--user’.
(cuirass-remote-worker-service-type): Add ACCOUNT-SERVICE-TYPE
extension.

Change-Id: I075ea02b6972adcad0a75e330073e85c4dacbbc5
---
 gnu/services/cuirass.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Hello!

This is fixing longstanding flakiness...

Ludo'.

diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm
index f68b4dc5a2..187766bc99 100644
--- a/gnu/services/cuirass.scm
+++ b/gnu/services/cuirass.scm
@@ -384,6 +384,19 @@ (define-record-type* <cuirass-remote-worker-configuration>
   (private-key      cuirass-remote-worker-configuration-private-key ;string
                     (default #f)))
 
+(define %cuirass-remote-worker-accounts
+  ;; User account and group for the 'cuirass remote-worker' process.
+  (list (user-group
+         (name "cuirass-worker")
+         (system? #t))
+        (user-account
+         (name "cuirass-worker")
+         (group name)
+         (system? #t)
+         (comment "Cuirass worker privilege separation user")
+         (home-directory "/var/empty")
+         (shell (file-append shadow "/sbin/nologin")))))
+
 (define (cuirass-remote-worker-shepherd-service config)
   "Return a <shepherd-service> for the Cuirass remote worker service with
 CONFIG."
@@ -397,6 +410,7 @@ (define (cuirass-remote-worker-shepherd-service config)
            (start #~(make-forkexec-constructor
                      (list (string-append #$cuirass "/bin/cuirass")
                            "remote-worker"
+                           "--user=cuirass-worker" ;drop privileges early on
                            (string-append "--workers="
                                           #$(number->string workers))
                            #$@(if server
@@ -444,6 +458,8 @@ (define cuirass-remote-worker-service-type
    (extensions
     (list (service-extension shepherd-root-service-type
                              cuirass-remote-worker-shepherd-service)
+          (service-extension account-service-type
+                             (const %cuirass-remote-worker-accounts))
           (service-extension rottlog-service-type
                              cuirass-remote-worker-log-rotations)))
    (description

base-commit: 6757bfdfc0b22a1e23a3d33566155550182244fc
-- 
2.46.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.