GNU bug report logs - #73809
[PATCH 0/2] gnu: Add go-github-com-kpango-glg.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73809 in the body.
You can then email your comments to 73809 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 0/2] gnu: Add go-github-com-kpango-glg.
Date: Tue, 15 Oct 2024 00:06:00 +0300

This patch series adds go-github-com-kpango-glg[1] and its dependencies.  I
took the responsibility and removed all the "blazing fast" prefixes from the
upstream package descriptions in READMEs so it may run slower now.  ;-)

avp.

References:
1. https://github.com/kpango/glg/

Artyom V. Poptsov (2):
  gnu: Add go-github-com-kpango-fastime.
  gnu: Add go-github-com-kpango-glg.

 gnu/packages/golang-xyz.scm | 50 +++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)


base-commit: 6d0a86d22d75f8f4bb602a35218513ae0aef71f1
-- 
2.46.0

Message #8 received at 73809 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 73809 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add go-github-com-kpango-fastime.
Date: Tue, 15 Oct 2024 00:07:30 +0300

* gnu/packages/golang-xyz.scm (go-github-com-kpango-fastime): New variable.

Change-Id: I79bf2cd7d0a3a29d2718788184560c0cfe406e4f
---
 gnu/packages/golang-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm
index 942c5f5138..d238eedc40 100644
--- a/gnu/packages/golang-xyz.scm
+++ b/gnu/packages/golang-xyz.scm
@@ -4061,6 +4061,30 @@ (define-public go-github-com-klauspost-cpuid-v2
      (list
       #:import-path "github.com/klauspost/cpuid/v2"))))
 
+(define-public go-github-com-kpango-fastime
+  (package
+    (name "go-github-com-kpango-fastime")
+    (version "1.1.9")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/kpango/fastime")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "18f1p5wf0zf73ky0h2hqfa6b6zryf7pq7k2r02if673x7bjlbp9h"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:import-path "github.com/kpango/fastime"))
+    (home-page "https://github.com/kpango/fastime")
+    (synopsis "Fast time function library for Go")
+    (description
+     "@code{fastime} is a time function library for Go with zero memory
+allocation.  @code{fastime} returns the approximate time.")
+    (license license:expat)))
+
 (define-public go-github-com-kr-pretty
   (package
     (name "go-github-com-kr-pretty")
-- 
2.46.0

Message #11 received at 73809 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 73809 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 2/2] gnu: Add go-github-com-kpango-glg.
Date: Tue, 15 Oct 2024 00:07:31 +0300

* gnu/packages/golang-xyz.scm (go-github-com-kpango-glg): New variable.

Change-Id: Iaa457f5a53000713df0a7fad3f772e57143c9d1c
---
 gnu/packages/golang-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm
index d238eedc40..98389ec0ae 100644
--- a/gnu/packages/golang-xyz.scm
+++ b/gnu/packages/golang-xyz.scm
@@ -4061,6 +4061,32 @@ (define-public go-github-com-klauspost-cpuid-v2
      (list
       #:import-path "github.com/klauspost/cpuid/v2"))))
 
+(define-public go-github-com-kpango-glg
+  (package
+    (name "go-github-com-kpango-glg")
+    (version "1.6.15")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/kpango/glg")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0k6y8nvj0q8mz362490cmcx15rhcpyx4sf4rv153dgh46acd1phh"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:import-path "github.com/kpango/glg"))
+    (propagated-inputs (list go-github-com-goccy-go-json
+                             go-github-com-kpango-fastime
+                             go-github-com-sirupsen-logrus
+                             go-go-uber-org-zap))
+    (home-page "https://github.com/kpango/glg")
+    (synopsis "Lock-free logging library for Go")
+    (description "@code{glg} is simple lock-free logging library for Go.")
+    (license license:expat)))
+
 (define-public go-github-com-kpango-fastime
   (package
     (name "go-github-com-kpango-fastime")
-- 
2.46.0

Message #14 received at 73809 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 73809 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH 0/2] gnu: Add go-github-com-kpango-glg.
Date: Tue, 15 Oct 2024 15:55:48 +0100

[Message part 1 (text/plain, inline)]

Hi,

QA is blazing fast for that patches, and it's green!

One neat pick:
- new lines for descriptions:
--8<---------------cut here---------------start------------->8---
(description
"@code{glg} is simple lock-free logging library for Go.")
--8<---------------cut here---------------end--------------->8---

- maybe, place list of inputs on a new line as well, and sort it, e.g.
--8<---------------cut here---------------start------------->8---
(propagated-inputs
  (list go-github-com-goccy-go-json
        go-github-com-kpango-fastime
        go-github-com-sirupsen-logrus
        go-go-uber-org-zap))
--8<---------------cut here---------------end--------------->8---

- some small style suggestion on this:
--8<---------------cut here---------------start------------->8---
+    (description
+     "@code{fastime} is a time function library for Go with zero memory
+allocation.  @code{fastime} returns the approximate time.")
--8<---------------cut here---------------end--------------->8---
> ... returning the approximate time.

You may apply styling adjustment before push, LGFM, feel free to push it.

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 73809-done <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 73809-done <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: Add go-github-com-kpango-glg.
Date: Tue, 15 Oct 2024 23:03:27 +0300

[Message part 1 (text/plain, inline)]

Reviewed by Sharlatan Hellseher <sharlatanus <at> gmail.com>.

Pushed to the "master" branch as:
- f5ae687319852ed3eca6bb83a139a2a9e71cbfe9
- 8ffb0c14b8abdbb471788f993a7835add147e3a8

Thanks,
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.