GNU bug report logs - #73809
[PATCH 0/2] gnu: Add go-github-com-kpango-glg.

Previous Next

Full log

View this message in rfc822 format

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 73809 <at> debbugs.gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [bug#73809] [PATCH 0/2] gnu: Add go-github-com-kpango-glg.
Date: Tue, 15 Oct 2024 15:55:48 +0100

[Message part 1 (text/plain, inline)]

Hi,

QA is blazing fast for that patches, and it's green!

One neat pick:
- new lines for descriptions:
--8<---------------cut here---------------start------------->8---
(description
"@code{glg} is simple lock-free logging library for Go.")
--8<---------------cut here---------------end--------------->8---

- maybe, place list of inputs on a new line as well, and sort it, e.g.
--8<---------------cut here---------------start------------->8---
(propagated-inputs
  (list go-github-com-goccy-go-json
        go-github-com-kpango-fastime
        go-github-com-sirupsen-logrus
        go-go-uber-org-zap))
--8<---------------cut here---------------end--------------->8---

- some small style suggestion on this:
--8<---------------cut here---------------start------------->8---
+    (description
+     "@code{fastime} is a time function library for Go with zero memory
+allocation.  @code{fastime} returns the approximate time.")
--8<---------------cut here---------------end--------------->8---
> ... returning the approximate time.

You may apply styling adjustment before push, LGFM, feel free to push it.

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.