GNU bug report logs - #73661
[PATCH] Anchor to first sibling unless bol-sibling found

Previous Next

Package: emacs;

Reported by: Jørgen Kvalsvik <j <at> lambda.is>

Date: Sun, 6 Oct 2024 16:06:02 UTC

Severity: normal

Tags: patch

Merged with 73662

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73662: closed ([PATCH] Anchor to first sibling unless
 bol-sibling found)
Date: Thu, 10 Oct 2024 07:08:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 10 Oct 2024 00:06:25 -0700
with message-id <65500369-261B-4FC9-805B-94F77EC4A21F <at> gmail.com>
and subject line Re: bug#73661: [PATCH] Anchor to first sibling unless bol-sibling found
has caused the debbugs.gnu.org bug report #73661,
regarding [PATCH] Anchor to first sibling unless bol-sibling found
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73661
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jørgen Kvalsvik <j <at> lambda.is>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Anchor to first sibling unless bol-sibling found
Date: Sun, 06 Oct 2024 16:03:44 +0200
[Message part 3 (text/plain, inline)]
Tags: patch


Indenting would give up when initializer lists and similar constructs
were broken up over multiple lines where the first item was not also
beginning-of-line.  Items should anchor on the first sibling (like with
function calls and init-lists in general). The search for a sibling to
anchor on should stop at the first sibling at bol or the first sibling
in the (sub)tree.

This brings indent up to c-mode parity for code like:

return { x1, x2, ...,
         y1, x2, ... };


In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu) of 2024-10-06 built
 on ada
Repository revision: c8e5f2ee9f6155ef545c2fe8ddf702c4f16a6eea
Repository branch: master
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --with-x-toolkit=no --with-xpm=ifavailable
 --with-jpeg=ifavailable --with-png=ifavailable --with-gif=ifavailable
 --with-tiff=ifavailable --with-gnutls=ifavailable --with-tree-sitter
 --with-native-compilation --prefix=/home/j/src/emacs/build/root'

[0001-Anchor-to-first-sibling-unless-bol-sibling-found.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73661-done <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>,
 Jørgen Kvalsvik <j <at> lambda.is>
Subject: Re: bug#73661: [PATCH] Anchor to first sibling unless bol-sibling
 found
Date: Thu, 10 Oct 2024 00:06:25 -0700

> On Oct 8, 2024, at 4:59 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Mon, 7 Oct 2024 17:12:22 -0700
>> Cc: 73661 <at> debbugs.gnu.org,
>> Theodor Thornhill <theo <at> thornhill.no>,
>> Eli Zaretskii <eliz <at> gnu.org>
>> 
>> Awesome! Thanks for the patch. Have you signed the copyright assignment? Eli, does this count as a significant contribution that requires the copyright assignment?
> 
> This is small enough to accept without paperwork.

Merged. Thanks!

Yuan

This bug report was last modified 227 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.