GNU bug report logs - #73661
[PATCH] Anchor to first sibling unless bol-sibling found

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73661 in the body.
You can then email your comments to 73661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jørgen Kvalsvik <j <at> lambda.is>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Anchor to first sibling unless bol-sibling found
Date: Sun, 06 Oct 2024 15:44:55 +0200

[Message part 1 (text/plain, inline)]

Tags: patch


Indenting would give up when initializer lists and similar constructs
were broken up over multiple lines where the first item was not also
beginning-of-line.  Items should anchor on the first sibling (like with
function calls and init-lists in general). The search for a sibling to
anchor on should stop at the first sibling at bol or the first sibling
in the (sub)tree.

This brings indent up to c-mode parity for code like:

return { x1, x2, ...,
         y1, x2, ... };



In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu) of 2024-10-06 built
 on ada
Repository revision: c8e5f2ee9f6155ef545c2fe8ddf702c4f16a6eea
Repository branch: master
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --with-x-toolkit=no --with-xpm=ifavailable
 --with-jpeg=ifavailable --with-png=ifavailable --with-gif=ifavailable
 --with-tiff=ifavailable --with-gnutls=ifavailable --with-tree-sitter
 --with-native-compilation --prefix=/home/j/src/emacs/build/root'

[0001-Anchor-to-first-sibling-unless-bol-sibling-found.patch (text/patch, attachment)]

Message #10 received at 73661 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Jørgen Kvalsvik <j <at> lambda.is>
Cc: 73661 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Theodor Thornhill <theo <at> thornhill.no>
Subject: Re: bug#73661: [PATCH] Anchor to first sibling unless bol-sibling
 found
Date: Mon, 7 Oct 2024 17:12:22 -0700

> On Oct 6, 2024, at 6:44 AM, Jørgen Kvalsvik <j <at> lambda.is> wrote:
> 
> Tags: patch
> 
> 
> Indenting would give up when initializer lists and similar constructs
> were broken up over multiple lines where the first item was not also
> beginning-of-line.  Items should anchor on the first sibling (like with
> function calls and init-lists in general). The search for a sibling to
> anchor on should stop at the first sibling at bol or the first sibling
> in the (sub)tree.
> 
> This brings indent up to c-mode parity for code like:
> 
> return { x1, x2, ...,
>         y1, x2, ... };

Awesome! Thanks for the patch. Have you signed the copyright assignment? Eli, does this count as a significant contribution that requires the copyright assignment?

Yuan

Message #13 received at 73661 <at> debbugs.gnu.org (full text, mbox):

From: Jørgen Kvalsvik <j <at> lambda.is>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 73661 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Theodor Thornhill <theo <at> thornhill.no>
Subject: Re: bug#73661: [PATCH] Anchor to first sibling unless bol-sibling
 found
Date: Tue, 8 Oct 2024 08:17:10 +0200

On 10/8/24 02:12, Yuan Fu wrote:
> 
> 
>> On Oct 6, 2024, at 6:44 AM, Jørgen Kvalsvik <j <at> lambda.is> wrote:
>>
>> Tags: patch
>>
>>
>> Indenting would give up when initializer lists and similar constructs
>> were broken up over multiple lines where the first item was not also
>> beginning-of-line.  Items should anchor on the first sibling (like with
>> function calls and init-lists in general). The search for a sibling to
>> anchor on should stop at the first sibling at bol or the first sibling
>> in the (sub)tree.
>>
>> This brings indent up to c-mode parity for code like:
>>
>> return { x1, x2, ...,
>>          y1, x2, ... };
> 
> Awesome! Thanks for the patch. Have you signed the copyright assignment? Eli, does this count as a significant contribution that requires the copyright assignment?
> 
> Yuan

I have requested the paperwork, but not signed yet.

Message #16 received at 73661 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 73661 <at> debbugs.gnu.org, theo <at> thornhill.no, j <at> lambda.is
Subject: Re: bug#73661: [PATCH] Anchor to first sibling unless bol-sibling
 found
Date: Tue, 08 Oct 2024 14:59:59 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Mon, 7 Oct 2024 17:12:22 -0700
> Cc: 73661 <at> debbugs.gnu.org,
>  Theodor Thornhill <theo <at> thornhill.no>,
>  Eli Zaretskii <eliz <at> gnu.org>
> 
> Awesome! Thanks for the patch. Have you signed the copyright assignment? Eli, does this count as a significant contribution that requires the copyright assignment?

This is small enough to accept without paperwork.

Message #21 received at 73661-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73661-done <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>,
 Jørgen Kvalsvik <j <at> lambda.is>
Subject: Re: bug#73661: [PATCH] Anchor to first sibling unless bol-sibling
 found
Date: Thu, 10 Oct 2024 00:06:25 -0700

> On Oct 8, 2024, at 4:59 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Mon, 7 Oct 2024 17:12:22 -0700
>> Cc: 73661 <at> debbugs.gnu.org,
>> Theodor Thornhill <theo <at> thornhill.no>,
>> Eli Zaretskii <eliz <at> gnu.org>
>> 
>> Awesome! Thanks for the patch. Have you signed the copyright assignment? Eli, does this count as a significant contribution that requires the copyright assignment?
> 
> This is small enough to accept without paperwork.

Merged. Thanks!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.