GNU bug report logs - #73651
[PATCH] gnu: dool: Update to 1.3.3.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73651 in the body.
You can then email your comments to 73651 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Subject: [PATCH] gnu: dool: Update to 1.3.3.
Date: Sun,  6 Oct 2024 09:53:04 +0300

* gnu/packages/admin.scm (dool): Update to 1.3.3.
[arguments]<phases>: Fix "check" phase by removing "-f" option from the dool
arguments as it leads to failures during tests but works after installation.
Don't remove "examples/dstat.py" as it is already removed in the upstream.

Change-Id: I22714bc03bf248b97ba8f21835aedb213e1b281b
---
 gnu/packages/admin.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 5c1b063d26..427e2778bd 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -3544,7 +3544,7 @@ (define-public dstat
 (define-public dool
   (package
     (name "dool")
-    (version "1.3.0")
+    (version "1.3.3")
     (source
      (origin
        (method git-fetch)
@@ -3553,7 +3553,7 @@ (define-public dool
              (commit (string-append "v" version))))
        (file-name (git-file-name "dool" version))
        (sha256
-        (base32 "1728wxy338gf2l06b0b4j9j8vihadw5whzzj7mi9p3by633h5s8m"))))
+        (base32 "0y5y5c07hgj6v2nvimnwc8myx43li8ib40hdvz7q4q1pdqx3r0jl"))))
     (build-system python-build-system)
     (arguments
      (list
@@ -3562,7 +3562,6 @@ (define-public dool
           (add-after 'unpack 'remove-symlinks-and-snap-packaging
             ;; Remove symlinks that make 'ensure-no-mtimes-pre-1980 fail.
             (lambda _
-              (delete-file "examples/dstat.py")
               (delete-file-recursively "packaging/snap")))
           (delete 'build)
           (replace 'install
@@ -3579,7 +3578,7 @@ (define-public dool
             (lambda* (#:key tests? #:allow-other-keys)
               (when tests?
                 (invoke "./dool" "--version")
-                (invoke "./dool" "-taf" "1" "5")))))))
+                (invoke "./dool" "-ta" "1" "5")))))))
     (synopsis "Command line system resource monitoring tool")
     (description "Dool is a command line tool to monitor many aspects of your
 system: CPU, Memory, Network, Load Average, etc.  It also includes a robust

base-commit: 002df8abd2f4d7c5d23febb1459b77c880345ca7
-- 
2.46.0

Message #8 received at 73651 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: control <at> debbugs.gnu.org, 73651 <at> debbugs.gnu.org
Subject: QA: review for 73651
Date: Mon, 7 Oct 2024 16:57:43 -0400

[Message part 1 (text/plain, inline)]

user guix
usertag 73651 + reviewed-looks-good
thanks

Guix QA review form submission:
Changes listed in the commit are correct, `dstat.py` was removed (the
entire examples directory was removed in commit
'dc7c1da9e1feaa98de7c70baa3b16529a8eda0ad') and something
about the '-f' or '--full' flag does cause tests to
fail in the guix build environment, but the flag does work after
building and calling in a normal shell environment.

Items marked as checked: Lint warnings, Package builds, Commit
messages, New package licenses, New package tests, New package synopsis
and descriptions

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: 73651-done <at> debbugs.gnu.org
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: dool: Update to 1.3.3.
Date: Sun, 13 Oct 2024 08:10:58 +0300

[Message part 1 (text/plain, inline)]

Pushed to the "master" as e032a0f38ff3394816fdc29554933ce77c545eff.

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.