GNU bug report logs - #73650
31.0.50; [PATCH] Improve correctness of Eshell conditional forms and allow if/else chaining

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73650 in the body.
You can then email your comments to 73650 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [PATCH] Improve correctness of Eshell conditional forms and
 allow if/else chaining
Date: Sat, 5 Oct 2024 18:34:24 -0700

[Message part 1 (text/plain, inline)]

These patches improve a few inconsistencies in how Eshell conditionals 
work, especially when using Lisp forms inside of the command-form of 
"if". For example, before this patch, the following command outputs 
nothing at all:

  if (zerop 0) (identity \"yes\") (identity \"no\")

With the patches, it now correctly outputs "yes".

I also added the ability to use the "else" keyword so that you can chain 
together if/else blocks like so:

  if {[ -f file.txt ]} {
    echo found file
  } else if {[ -f alternate.txt ]} {
    echo found alternate
  } else {
    echo not found!
  }

[0001-Simplify-creation-of-Eshell-command-forms.patch (text/plain, attachment)]

[0002-Improve-correctness-of-Eshell-sub-forms.patch (text/plain, attachment)]

[0003-Add-support-for-chaining-conditionals-in-Eshell.patch (text/plain, attachment)]

Message #10 received at 73650-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 73650-done <at> debbugs.gnu.org
Subject: Re: bug#73650: 31.0.50; [PATCH] Improve correctness of Eshell
 conditional forms and allow if/else chaining
Date: Wed, 16 Oct 2024 21:56:01 -0700

On 10/5/2024 6:34 PM, Jim Porter wrote:
> These patches improve a few inconsistencies in how Eshell conditionals 
> work, especially when using Lisp forms inside of the command-form of 
> "if".

Merged to the master branch as fada04cfc78, and closing this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.