GNU bug report logs - #73583
[PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73583 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
Date: Tue, 15 Oct 2024 08:41:37 +0200

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.

Thank you. Some comments follow.

>          #:exclude #~(list
> -                     ;; github.com/jkitchin/org-ref/issues/1085
> -                     "openalex.el"

Why are you removing these lines? There is no mention about it in your
commit message.

>                       ;; author doesn't recommend using it
>                       "org-ref-pdf.el")))
>        (propagated-inputs
> -       (list emacs-avy
> -             emacs-citeproc-el
> -             emacs-dash
> -             emacs-f
> -             emacs-helm
> -             emacs-helm-bibtex
> -             emacs-htmlize
> -             emacs-hydra
> -             emacs-ivy
> -             emacs-ox-pandoc
> -             emacs-parsebib
> -             emacs-s))
> +       (list
> +        emacs-dash
> +        emacs-s
> +        emacs-f
> +        emacs-htmlize
> +        emacs-hydra
> +        emacs-avy
> +        emacs-parsebib
> +        emacs-helm-bibtex
> +        emacs-citeproc-el
> +        emacs-ox-pandoc
> +        emacs-request))

I don't understand the purpose of this change either. You're breaking
alphabetic order and use a dubious indentation.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.