GNU bug report logs - #73583
[PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73583 in the body.
You can then email your comments to 73583 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
Date: Tue,  1 Oct 2024 19:20:50 +0200

* gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.
---
 gnu/packages/emacs-xyz.scm | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e9ecbea48..6c4739e8c0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26160,11 +26160,11 @@ (define-public emacs-discover-my-major
     (license license:gpl3+)))
 
 (define-public emacs-org-ref
-  (let ((commit "bb375f366f883e5b60e3bb625f2acd026811fb55")
+  (let ((commit "732a20bd236fd02db4a651da29f87f87f458a54a")
         (revision "0"))
     (package
       (name "emacs-org-ref")
-      (version (git-version "3.0" revision commit))
+      (version (git-version "3.1" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -26174,29 +26174,27 @@ (define-public emacs-org-ref
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "01wxcyzdrx6ysv9rjd64fr7kkvm4fjr03ib4mmpchraxxm8g8z43"))))
+           "1kbjxz56fvln6drd2wqdxrpgwjshzpdbyaq7dz0gn285z93y1knk"))))
       (build-system emacs-build-system)
       (arguments
        (list
         #:include #~(cons* "org-ref.org" "org-ref.bib" %default-include)
         #:exclude #~(list
-                     ;; github.com/jkitchin/org-ref/issues/1085
-                     "openalex.el"
                      ;; author doesn't recommend using it
                      "org-ref-pdf.el")))
       (propagated-inputs
-       (list emacs-avy
-             emacs-citeproc-el
-             emacs-dash
-             emacs-f
-             emacs-helm
-             emacs-helm-bibtex
-             emacs-htmlize
-             emacs-hydra
-             emacs-ivy
-             emacs-ox-pandoc
-             emacs-parsebib
-             emacs-s))
+       (list
+        emacs-dash
+        emacs-s
+        emacs-f
+        emacs-htmlize
+        emacs-hydra
+        emacs-avy
+        emacs-parsebib
+        emacs-helm-bibtex
+        emacs-citeproc-el
+        emacs-ox-pandoc
+        emacs-request))
       (home-page "https://github.com/jkitchin/org-ref")
       (synopsis "Citations, cross-references and bibliographies in Org mode")
       (description

base-commit: 71fef00c95b22a1d917abdb28de5aa217b023e31
-- 
2.46.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73583 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
Date: Tue, 15 Oct 2024 08:41:37 +0200

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.

Thank you. Some comments follow.

>          #:exclude #~(list
> -                     ;; github.com/jkitchin/org-ref/issues/1085
> -                     "openalex.el"

Why are you removing these lines? There is no mention about it in your
commit message.

>                       ;; author doesn't recommend using it
>                       "org-ref-pdf.el")))
>        (propagated-inputs
> -       (list emacs-avy
> -             emacs-citeproc-el
> -             emacs-dash
> -             emacs-f
> -             emacs-helm
> -             emacs-helm-bibtex
> -             emacs-htmlize
> -             emacs-hydra
> -             emacs-ivy
> -             emacs-ox-pandoc
> -             emacs-parsebib
> -             emacs-s))
> +       (list
> +        emacs-dash
> +        emacs-s
> +        emacs-f
> +        emacs-htmlize
> +        emacs-hydra
> +        emacs-avy
> +        emacs-parsebib
> +        emacs-helm-bibtex
> +        emacs-citeproc-el
> +        emacs-ox-pandoc
> +        emacs-request))

I don't understand the purpose of this change either. You're breaking
alphabetic order and use a dubious indentation.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 73583 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 73583 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
Date: Tue, 15 Oct 2024 10:10:21 +0200

* gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.

Change-Id: I04f4cb9ffacaaf25a3e844c8e1d1b194e41d90a9
---

Update to 3.1-0.732a20b.

The reason to exclude openalex.el from this package doesn't hold anymore, see github.com/jkitchin/org-ref/issues/1085.

Emacs-helm is already pulled from emacs-helm-bibtex, no need to do it here.

Emacs-request is a new hard dependency. Emacs-ivy is not.

 gnu/packages/emacs-xyz.scm | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e9ecbea48..ed1618fd4d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26160,11 +26160,11 @@ (define-public emacs-discover-my-major
     (license license:gpl3+)))
 
 (define-public emacs-org-ref
-  (let ((commit "bb375f366f883e5b60e3bb625f2acd026811fb55")
+  (let ((commit "732a20bd236fd02db4a651da29f87f87f458a54a")
         (revision "0"))
     (package
       (name "emacs-org-ref")
-      (version (git-version "3.0" revision commit))
+      (version (git-version "3.1" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -26174,14 +26174,12 @@ (define-public emacs-org-ref
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "01wxcyzdrx6ysv9rjd64fr7kkvm4fjr03ib4mmpchraxxm8g8z43"))))
+           "1kbjxz56fvln6drd2wqdxrpgwjshzpdbyaq7dz0gn285z93y1knk"))))
       (build-system emacs-build-system)
       (arguments
        (list
         #:include #~(cons* "org-ref.org" "org-ref.bib" %default-include)
         #:exclude #~(list
-                     ;; github.com/jkitchin/org-ref/issues/1085
-                     "openalex.el"
                      ;; author doesn't recommend using it
                      "org-ref-pdf.el")))
       (propagated-inputs
@@ -26189,14 +26187,12 @@ (define-public emacs-org-ref
              emacs-citeproc-el
              emacs-dash
              emacs-f
-             emacs-helm
              emacs-helm-bibtex
              emacs-htmlize
              emacs-hydra
-             emacs-ivy
              emacs-ox-pandoc
              emacs-parsebib
+             emacs-request
              emacs-s))
       (home-page "https://github.com/jkitchin/org-ref")
       (synopsis "Citations, cross-references and bibliographies in Org mode")
--
2.46.0

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 73583 <at> debbugs.gnu.org,
 Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
Date: Tue, 15 Oct 2024 10:16:02 +0200

>mar. 15 oct. 2024 at 08:41, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:

> Why are you removing these lines? There is no mention about it in your
> commit message.

The reason to exclude this file doesn’t hold anymore, see
github.com/jkitchin/org-ref/issues/1085. 

> I don't understand the purpose of this change either. You're breaking
> alphabetic order and use a dubious indentation.

Sorry for that. I submitted a v1 patch with corrections and text.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 73583-done <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#73583] [PATCH v1] gnu: emacs-org-ref: Update to
 3.1-0.732a20b.
Date: Sun, 27 Oct 2024 11:22:43 +0100

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.