GNU bug report logs - #73522
[PATCH 0/6] Package and use RetroArch assets, plus other improvements.

Previous Next

Full log

Message #79 received at 73522-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 73522-done <at> debbugs.gnu.org, Sergey Trofimov <sarg <at> sarg.org.ru>,
 宋文武 <iyzsong <at> envs.net>, Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#73522] [PATCH games-team 06/14] gnu: retroarch: Clean-up
 source from extraneous bundled libraries.
Date: Mon, 07 Oct 2024 01:26:29 +0900

Hi again,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

[...]

>> Can we unvendor spirv-cross?
>
> It could be done, but it'd have to be new development as their build
> system doesn't currently support it.  I'll give it another try right
> now, but if it becomes too much work, I'll drop it.

I've spent the evening on it, but in the end it works!

>>> +                            "discord-rpc"   ;used in
>>> network/discord.h
>> Can we drop this discord thing?
>
> Not easily, no.  I had checked and there's no switch to opt out in the
> build system.

Actually I was wrong, after getting more knowledgeable about its
'quickbuild / qb' build configure script. I could pass --disable-discord
and a bunch of others to remove support provided via bundled libraries.

I've now push the series (see commit 3e9ebe7f28 and previous ones) with
these changes; you are welcome to inspect the result and let me know if
something is amiss.

Thanks for the review.

Happy hacking!

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.