GNU bug report logs - #73523
[PATCH 0/3] gnu: add pywlroots

Previous Next

Package: guix-patches;

Reported by: bigbookofbug <at> proton.me

Date: Sat, 28 Sep 2024 05:33:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 73523 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Sat, 28 Sep 2024 05:33:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to bigbookofbug <at> proton.me:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 28 Sep 2024 05:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: bigbookofbug <at> proton.me
To: guix-patches <at> gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH 0/3] gnu: add pywlroots
Date: Sat, 28 Sep 2024 05:00:42 +0000
From: big bug <bigbookofbug <at> proton.me>

This is a series of patches building pywlroots and its dependencies. These can be used to eventually build a version of qtile with wayland support.

big bug (3):
  gnu: add python-pywlroots
  gnu: add pywlroots
  gnu: add pywlroots

 gnu/packages/python-xyz.scm | 79 +++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)


base-commit: 5e888ec915cfdd256e726959cdc23293bc36277e
-- 
2.46.0






Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Sat, 28 Sep 2024 06:37:01 GMT) Full text and rfc822 format available.

Message #8 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: bigbookofbug <at> proton.me
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH 1/3] [PATCH 0/3] gnu: add python-pywlroots
Date: Sat, 28 Sep 2024 06:35:32 +0000
From: big bug <bigbookofbug <at> proton.me>

---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 22351e813a..83f645a038 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -155,6 +155,7 @@
 ;;; Copyright © 2024 David Elsing <david.elsing <at> posteo.net>
 ;;; Copyright © 2024 Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
 ;;; Copyright © 2024 Peter Kannewitz <petre-vps <at> posteo.net>
+;;; Copyright © 2024 big bug <bigbookofbug <at> proton.me>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -11023,6 +11024,28 @@ (define-public python-pywal
 your favourite programs.")
     (license license:expat)))
 
+(define-public python-pywayland
+  (package
+    (name "python-pywayland")
+    (version "0.4.18")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pywayland" version))
+       (sha256
+	(base32 "0cv5aqn23id31mn95q6isn5vcnjcd4dvaqzn52ihbb9sg01dx2jr"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:tests? #f))
+    (inputs (list wayland))
+    (propagated-inputs (list python-cffi))
+    (native-inputs (list python-pytest pkg-config))
+    (home-page "https://github.com/flacjacket/pywayland/")
+    (synopsis "Python bindings for the libwayland librar")
+    (description "PyWayland provides a wrapper to the libwayland library using the CFFI library to provide access to the Wayland library calls and written in pure Python.")
+    (license license:asl2.0)))
+
 (define-public python-click-didyoumean
   (package
     (name "python-click-didyoumean")
-- 
2.46.0






Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Sat, 28 Sep 2024 06:37:02 GMT) Full text and rfc822 format available.

Message #11 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: bigbookofbug <at> proton.me
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH 3/3] [PATCH 3/3] gnu: add pywlroots
Date: Sat, 28 Sep 2024 06:35:47 +0000
From: big bug <bigbookofbug <at> proton.me>

---
 gnu/packages/python-xyz.scm | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 29a48dacaa..4a0b74d4f9 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11064,6 +11064,44 @@ (define-public python-pywayland
     (description "PyWayland provides a wrapper to the libwayland library using the CFFI library to provide access to the Wayland library calls and written in pure Python.")
     (license license:asl2.0)))
 
+(define-public python-pywlroots
+  (package
+   (name "python-pywlroots")
+   (version "0.17.0")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (pypi-uri "pywlroots" version))
+     (sha256
+      (base32 "1frxqkkh2867rh0c6j0jsmzrga8k6235f6ygkk4cph2883hjpjvj"))))
+   (build-system pyproject-build-system)
+   (arguments
+    (list
+     #:tests? #f
+     #:phases
+     #~(modify-phases %standard-phases
+		      (add-before 'build 'pre-build
+				  ;;needed, otherwise pixman.h will not be found
+				  (lambda* (#:key inputs #:allow-other-keys)
+				    (let ((pixman (string-append
+						   (assoc-ref inputs "pixman")
+						   "/include")))
+				      (setenv "C_INCLUDE_PATH"
+					      (string-append pixman "/" "pixman-1" ":"
+							     (or (getenv "C_INCLUDE_PATH")
+								 "")))))))))
+   (inputs
+    (list pixman wayland libinput libxkbcommon wlroots))
+   (propagated-inputs (list python-pywayland python-xkbcommon))
+   (native-inputs (append (if (%current-target-system)
+			      (list pkg-config-for-build wayland) '())
+			  (list pkg-config
+				python-cffi)))
+   (home-page "https://github.com/flacjacket/pywlroots")
+   (synopsis "Python binding to the wlroots library using cffi.")
+   (description "A Python binding to the wlroots library using cffi. The library uses pywayland to provide the Wayland bindings and python-xkbcommon to provide wlroots keyboard functionality.")
+   (license license:ncsa)))
+
 (define-public python-click-didyoumean
   (package
     (name "python-click-didyoumean")
-- 
2.46.0






Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Sat, 28 Sep 2024 06:41:02 GMT) Full text and rfc822 format available.

Message #14 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: bigbookofbug <at> proton.me
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH 2/3] [PATCH 2/3] gnu: add pywlroots
Date: Sat, 28 Sep 2024 06:35:39 +0000
From: big bug <bigbookofbug <at> proton.me>

---
 gnu/packages/python-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 83f645a038..29a48dacaa 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -458,6 +458,24 @@ (define-public python-awkward
 using NumPy-like idioms.")
     (license license:bsd-3)))
 
+(define-public python-xkbcommon
+  (package
+    (name "python-xkbcommon")
+    (version "1.5.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "xkbcommon" version))
+       (sha256
+	(base32 "0dnwbp8rriwkmsa8a40cpvrccjy7m8xz6jw0vbcka7gnvc44h5xc"))))
+    (build-system pyproject-build-system)
+    (inputs (list libxkbcommon))
+    (propagated-inputs (list python-cffi))
+    (home-page "https://github.com/sde1000/python-xkbcommon")
+    (synopsis "Python bindings for libxkbcommon using cffi")
+    (description "This package provides Python bindings for libxkcommon using python-cffi.")
+    (license license:expat)))
+
 (define-public python-xmldiff
   (package
     (name "python-xmldiff")
-- 
2.46.0






Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Sat, 28 Sep 2024 06:56:02 GMT) Full text and rfc822 format available.

Message #17 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: bigbookofbug <at> proton.me
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH 2/3] [PATCH 2/3] gnu: add pywlroots
Date: Sat, 28 Sep 2024 06:40:06 +0000
From: big bug <bigbookofbug <at> proton.me>

---
 gnu/packages/python-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 83f645a038..29a48dacaa 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -458,6 +458,24 @@ (define-public python-awkward
 using NumPy-like idioms.")
     (license license:bsd-3)))
 
+(define-public python-xkbcommon
+  (package
+    (name "python-xkbcommon")
+    (version "1.5.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "xkbcommon" version))
+       (sha256
+	(base32 "0dnwbp8rriwkmsa8a40cpvrccjy7m8xz6jw0vbcka7gnvc44h5xc"))))
+    (build-system pyproject-build-system)
+    (inputs (list libxkbcommon))
+    (propagated-inputs (list python-cffi))
+    (home-page "https://github.com/sde1000/python-xkbcommon")
+    (synopsis "Python bindings for libxkbcommon using cffi")
+    (description "This package provides Python bindings for libxkcommon using python-cffi.")
+    (license license:expat)))
+
 (define-public python-xmldiff
   (package
     (name "python-xmldiff")
-- 
2.46.0






Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Fri, 25 Oct 2024 00:24:02 GMT) Full text and rfc822 format available.

Message #20 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH v3 1/3] gnu: Add python-xkbcommon version 1.5.1
Date: Thu, 24 Oct 2024 20:20:29 -0400
From: big bug <bigbookofbug <at> proton.me>

* gnu/packages/python-xyz.scm (python-xkbcommon): New variable.
---
 gnu/packages/python-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b58eb1ff88..5001732d4d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -457,6 +457,25 @@ (define-public python-awkward
 using NumPy-like idioms.")
     (license license:bsd-3)))
 
+(define-public python-xkbcommon
+  (package
+    (name "python-xkbcommon")
+    (version "1.5.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "xkbcommon" version))
+       (sha256
+        (base32 "0dnwbp8rriwkmsa8a40cpvrccjy7m8xz6jw0vbcka7gnvc44h5xc"))))
+    (build-system pyproject-build-system)
+    (inputs (list libxkbcommon))
+    (propagated-inputs (list python-cffi))
+    (home-page "https://github.com/sde1000/python-xkbcommon")
+    (synopsis "Python bindings for libxkbcommon using cffi")
+    (description
+     "This package provides Python bindings for libxkcommon using python-cffi.")
+    (license license:expat)))
+
 (define-public python-xmldiff
   (package
     (name "python-xmldiff")

base-commit: 2394a7f5fbf60dd6adc0a870366adb57166b6d8b
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Fri, 25 Oct 2024 00:24:02 GMT) Full text and rfc822 format available.

Message #23 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH v3 2/3] gnu: Add pywayland version 0.4.18
Date: Thu, 24 Oct 2024 20:20:30 -0400
From: big bug <bigbookofbug <at> proton.me>

* gnu/packages/python-xyz (python-pywayland): New variable.
---
 gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5001732d4d..41ed393f67 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -155,6 +155,7 @@
 ;;; Copyright © 2024 David Elsing <david.elsing <at> posteo.net>
 ;;; Copyright © 2024 Rick Huijzer <ikbenrickhuyzer <at> gmail.com>
 ;;; Copyright © 2024 Peter Kannewitz <petre-vps <at> posteo.net>
+;;; Copyright © 2024 big bug <bigbookofbug <at> proton.me>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -37124,6 +37125,31 @@ (define-public python-wasabi
 toolkit for Python.")
     (license license:expat)))
 
+(define-public python-pywayland
+  (package
+    (name "python-pywayland")
+    (version "0.4.18")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pywayland" version))
+       (sha256
+        (base32 "0cv5aqn23id31mn95q6isn5vcnjcd4dvaqzn52ihbb9sg01dx2jr"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:tests? #f))
+    (inputs (list wayland))
+    (propagated-inputs (list python-cffi))
+    (native-inputs (list python-pytest pkg-config))
+    (home-page "https://github.com/flacjacket/pywayland/")
+    (synopsis "Python bindings for the libwayland librar")
+    (description
+     "PyWayland provides a wrapper to the libwayland library using the CFFI
+library to provide access to the Wayland library calls and written in pure
+Python.")
+    (license license:asl2.0)))
+
 (define-public python-srt
   (package
     (name "python-srt")
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Fri, 25 Oct 2024 00:24:03 GMT) Full text and rfc822 format available.

Message #26 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73523 <at> debbugs.gnu.org
Cc: big bug <bigbookofbug <at> proton.me>
Subject: [PATCH v3 3/3] gnu: Add pywlroots version 0.17.0
Date: Thu, 24 Oct 2024 20:20:31 -0400
From: big bug <bigbookofbug <at> proton.me>

* gnu/packages/python-xyz (python-pywlroots): New variable.
---
 gnu/packages/python-xyz.scm | 39 +++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 41ed393f67..d22fef08b9 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -287,6 +287,7 @@ (define-module (gnu packages python-xyz)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages wm)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xdisorg)
@@ -37150,6 +37151,44 @@ (define-public python-pywayland
 Python.")
     (license license:asl2.0)))
 
+(define-public python-pywlroots
+  (package
+    (name "python-pywlroots")
+    (version "0.17.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pywlroots" version))
+       (sha256
+        (base32 "1frxqkkh2867rh0c6j0jsmzrga8k6235f6ygkk4cph2883hjpjvj"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:tests? #f
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'build 'pre-build
+                     ;; needed, otherwise pixman.h will not be found
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (let ((pixman (string-append (assoc-ref inputs "pixman")
+                                                    "/include")))
+                         (setenv "C_INCLUDE_PATH"
+                                 (string-append pixman "/" "pixman-1" ":"
+                                                (or (getenv "C_INCLUDE_PATH")
+                                                    "")))))))))
+    (inputs (list pixman wayland libinput libxkbcommon wlroots))
+    (propagated-inputs (list python-pywayland python-xkbcommon))
+    (native-inputs (append (if (%current-target-system)
+                               (list pkg-config-for-build wayland)
+                               '())
+                           (list pkg-config python-cffi)))
+    (home-page "https://github.com/flacjacket/pywlroots")
+    (synopsis "Python binding to the wlroots library using cffi")
+    (description
+     "A Python binding to the wlroots library using cffi.  The library uses
+pywayland to provide the Wayland bindings and python-xkbcommon to provide
+wlroots keyboard functionality.")
+    (license license:ncsa)))
+
 (define-public python-srt
   (package
     (name "python-srt")
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Fri, 25 Oct 2024 00:38:01 GMT) Full text and rfc822 format available.

Message #29 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 73523 <at> debbugs.gnu.org, bigbookofbug <at> proton.me
Subject: Issue 73523 adjustments
Date: Thu, 24 Oct 2024 20:35:22 -0400
Hello big bug,

Thank you for your submission; I modified the patch files as they were
all garbled when pulled down and failed to apply. I'm curious as to how
the original commits were created, were they by chance manually copied
up instead of being sent using git:send-email? Here is a StackOverflow
on how to setup
git:send-email: https://stackoverflow.com/q/68238912 it is for gmail
instead of proton mail, but should give a general idea (and if you
can't link proton mail this way, you can always create an anonymous
gmail to send in patches (someone else can chime in if there is an
alternate way to send patches that is more compatible with proton
mail/manual copy paste).

Additionally, Guix has additional documentation on how to send in
patches (and patch series):
1. https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
2. https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html

For future reviewers, I have not extensively checked out the
patches/verified that they are working; but they should now build
successfully.

v/r,

Aaron

P.S.

There is also the Mumi interface for sending patches, but I have yet to
try it personally:
* https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html




Information forwarded to guix-patches <at> gnu.org:
bug#73523; Package guix-patches. (Fri, 25 Oct 2024 17:05:02 GMT) Full text and rfc822 format available.

Message #32 received at 73523 <at> debbugs.gnu.org (full text, mbox):

From: emma <bigbookofbug <at> proton.me>
To: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Cc: 73523 <at> debbugs.gnu.org
Subject: Re: Issue 73523 adjustments
Date: Fri, 25 Oct 2024 17:04:10 +0000
[Message part 1 (text/plain, inline)]
"Aaron Covrig" <aaron.covrig.us <at> ieee.org> writes:

> Hello big bug,
>
> Thank you for your submission; I modified the patch files as 
> they were
> all garbled when pulled down and failed to apply. I'm curious as 
> to how
> the original commits were created, were they by chance manually 
> copied
> up instead of being sent using git:send-email? Here is a 
> StackOverflow
> on how to setup
> git:send-email: https://stackoverflow.com/q/68238912 it is for 
> gmail
> instead of proton mail, but should give a general idea (and if 
> you
> can't link proton mail this way, you can always create an 
> anonymous
> gmail to send in patches (someone else can chime in if there is 
> an
> alternate way to send patches that is more compatible with 
> proton
> mail/manual copy paste).
>
> Additionally, Guix has additional documentation on how to send 
> in
> patches (and patch series):
> 1. https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
> 2. https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html
>
> For future reviewers, I have not extensively checked out the
> patches/verified that they are working; but they should now 
> build
> successfully.
>
> v/r,
>
> Aaron
>
> P.S.
>
> There is also the Mumi interface for sending patches, but I have 
> yet to
> try it personally:
> * 
> https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html

hello aaron,
thank you for formatting and the links!
this was my first attempt using git send-email, and was 
encountering several issues, which may be the source of the 
garbling. the original commits were made using the steps laid out 
in 
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html, 
but the aforementioned issues had me having to resend the failed 
emails from my proton account. i've since resolved it so i future 
patch submissions should not be garbled.

emma

--
emma
EF515F7D600717781DF9AB2E0FB1CF2867A117F5
[signature.asc (application/pgp-signature, attachment)]

This bug report was last modified 233 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.