GNU bug report logs - #73487
[PATCH] ; * src/cm.c (cmgoto): Add function documentation

Previous Next

Package: emacs;

Reported by: Jeremy Bryant <jb <at> jeremybryant.net>

Date: Wed, 25 Sep 2024 21:34:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jeremy Bryant <jb <at> jeremybryant.net>
Subject: bug#73487: closed (Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto):
 Add function documentation)
Date: Fri, 27 Sep 2024 06:22:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 73487 <at> debbugs.gnu.org.

-- 
73487: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73487
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: 73487-done <at> debbugs.gnu.org
Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function
 documentation
Date: Fri, 27 Sep 2024 09:20:58 +0300
> From: Jeremy Bryant <jb <at> jeremybryant.net>
> Cc: 73487 <at> debbugs.gnu.org
> Date: Thu, 26 Sep 2024 22:54:36 +0100
> 
> > We usually prefer non-block comments, certainly when the comment is
> > short.  Can you use that in this case?
> >
> > Thanks.
> 
> Yes, sure.  Revised patch attached with the comment in a single line,
> rather than a block.

Thanks, installed, with 2 more nits I failed to mention.

> (I tried to match the style of the surrounding areas of the file but now
> realise this was from 1992)

Yeah, this is WIP...

[Message part 3 (message/rfc822, inline)]
From: Jeremy Bryant <jb <at> jeremybryant.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation
Date: Wed, 25 Sep 2024 22:32:56 +0100
[Message part 4 (text/plain, inline)]
This proposed patch adds a function documentation where there was none.

Please install on master or provide feedback for further work.


[0001-src-cm.c-cmgoto-Add-function-documentation.patch (text/x-diff, attachment)]

This bug report was last modified 274 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.