GNU bug report logs - #73487
[PATCH] ; * src/cm.c (cmgoto): Add function documentation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73487 in the body.
You can then email your comments to 73487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation
Date: Wed, 25 Sep 2024 22:32:56 +0100

[Message part 1 (text/plain, inline)]

This proposed patch adds a function documentation where there was none.

Please install on master or provide feedback for further work.

[0001-src-cm.c-cmgoto-Add-function-documentation.patch (text/x-diff, attachment)]

Message #8 received at 73487 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: 73487 <at> debbugs.gnu.org
Subject: Re: bug#73487: [PATCH] ;
 * src/cm.c (cmgoto): Add function documentation
Date: Thu, 26 Sep 2024 10:22:42 +0300

> Date: Wed, 25 Sep 2024 22:32:56 +0100
> From:  Jeremy Bryant via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> This proposed patch adds a function documentation where there was none.
> 
> Please install on master or provide feedback for further work.

We usually prefer non-block comments, certainly when the comment is
short.  Can you use that in this case?

Thanks.

Message #11 received at 73487 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73487 <at> debbugs.gnu.org
Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function
 documentation
Date: Thu, 26 Sep 2024 22:54:36 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Wed, 25 Sep 2024 22:32:56 +0100
>> From:  Jeremy Bryant via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> This proposed patch adds a function documentation where there was none.
>> 
>> Please install on master or provide feedback for further work.
>
> We usually prefer non-block comments, certainly when the comment is
> short.  Can you use that in this case?
>
> Thanks.

Yes, sure.  Revised patch attached with the comment in a single line,
rather than a block.

(I tried to match the style of the surrounding areas of the file but now
realise this was from 1992)

Please install on master or provide feedback for further work.

[0001-src-cm.c-cmgoto-Add-function-documentation.patch (text/x-diff, attachment)]

Message #16 received at 73487-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: 73487-done <at> debbugs.gnu.org
Subject: Re: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function
 documentation
Date: Fri, 27 Sep 2024 09:20:58 +0300

> From: Jeremy Bryant <jb <at> jeremybryant.net>
> Cc: 73487 <at> debbugs.gnu.org
> Date: Thu, 26 Sep 2024 22:54:36 +0100
> 
> > We usually prefer non-block comments, certainly when the comment is
> > short.  Can you use that in this case?
> >
> > Thanks.
> 
> Yes, sure.  Revised patch attached with the comment in a single line,
> rather than a block.

Thanks, installed, with 2 more nits I failed to mention.

> (I tried to match the style of the surrounding areas of the file but now
> realise this was from 1992)

Yeah, this is WIP...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.