GNU bug report logs - #73463
[PATCH] Align columns with wide characters properly

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73463: closed ([PATCH] Align columns with wide characters
 properly)
Date: Wed, 25 Sep 2024 11:58:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 25 Sep 2024 14:57:03 +0300
with message-id <86ed58c5f4.fsf <at> gnu.org>
and subject line Re: bug#73463: [PATCH] Align columns with wide characters properly
has caused the debbugs.gnu.org bug report #73463,
regarding [PATCH] Align columns with wide characters properly
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73463: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73463
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Thomas Voss" <mail <at> thomasvoss.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Align columns with wide characters properly
Date: Wed, 25 Sep 2024 02:23:29 +0200

[Message part 3 (text/plain, inline)]

Hi all,

For a while I’ve been bugged by some behaviour in Which-Key.  My font of
choice is Iosevka — a font that is quite popular — and it chooses to make
the ellipsis character 2-columns wide.  This is typically not a problem,
but it causes Which-Key columns to appear misaligned as it truncates long
descriptions with the ellipsis by default when the user configures it to
use Unicode (and I rather enjoy the ellipsis).

This happens despite the following being in my init.el:

    (set-char-table-range char-width-table ?… 2)

After further investigation, this appears to be due to a simple usage of
‘length’ instead of ‘string-width’.  The following trivial patch attached
to this email seems to have solved this issue.

-- 
— Thomas

[0001-Align-columns-with-wide-characters-properly.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Thomas Voss" <mail <at> thomasvoss.com>
Cc: 73463-done <at> debbugs.gnu.org
Subject: Re: bug#73463: [PATCH] Align columns with wide characters properly
Date: Wed, 25 Sep 2024 14:57:03 +0300

> Date: Wed, 25 Sep 2024 02:23:29 +0200
> From:  "Thomas Voss" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> For a while I’ve been bugged by some behaviour in Which-Key.  My font of
> choice is Iosevka — a font that is quite popular — and it chooses to make
> the ellipsis character 2-columns wide.  This is typically not a problem,
> but it causes Which-Key columns to appear misaligned as it truncates long
> descriptions with the ellipsis by default when the user configures it to
> use Unicode (and I rather enjoy the ellipsis).
> 
> This happens despite the following being in my init.el:
> 
>     (set-char-table-range char-width-table ?… 2)
> 
> After further investigation, this appears to be due to a simple usage of
> ‘length’ instead of ‘string-width’.  The following trivial patch attached
> to this email seems to have solved this issue.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.