GNU bug report logs - #73463
[PATCH] Align columns with wide characters properly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73463 in the body.
You can then email your comments to 73463 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Thomas Voss" <mail <at> thomasvoss.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Align columns with wide characters properly
Date: Wed, 25 Sep 2024 02:23:29 +0200

[Message part 1 (text/plain, inline)]

Hi all,

For a while I’ve been bugged by some behaviour in Which-Key.  My font of
choice is Iosevka — a font that is quite popular — and it chooses to make
the ellipsis character 2-columns wide.  This is typically not a problem,
but it causes Which-Key columns to appear misaligned as it truncates long
descriptions with the ellipsis by default when the user configures it to
use Unicode (and I rather enjoy the ellipsis).

This happens despite the following being in my init.el:

    (set-char-table-range char-width-table ?… 2)

After further investigation, this appears to be due to a simple usage of
‘length’ instead of ‘string-width’.  The following trivial patch attached
to this email seems to have solved this issue.

-- 
— Thomas

[0001-Align-columns-with-wide-characters-properly.patch (text/x-patch, attachment)]

Message #10 received at 73463-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Thomas Voss" <mail <at> thomasvoss.com>
Cc: 73463-done <at> debbugs.gnu.org
Subject: Re: bug#73463: [PATCH] Align columns with wide characters properly
Date: Wed, 25 Sep 2024 14:57:03 +0300

> Date: Wed, 25 Sep 2024 02:23:29 +0200
> From:  "Thomas Voss" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> For a while I’ve been bugged by some behaviour in Which-Key.  My font of
> choice is Iosevka — a font that is quite popular — and it chooses to make
> the ellipsis character 2-columns wide.  This is typically not a problem,
> but it causes Which-Key columns to appear misaligned as it truncates long
> descriptions with the ellipsis by default when the user configures it to
> use Unicode (and I rather enjoy the ellipsis).
> 
> This happens despite the following being in my init.el:
> 
>     (set-char-table-range char-width-table ?… 2)
> 
> After further investigation, this appears to be due to a simple usage of
> ‘length’ instead of ‘string-width’.  The following trivial patch attached
> to this email seems to have solved this issue.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.