GNU bug report logs - #73412
31.0.50; Improve sql-read-product

Previous Next

Full log

Message #8 received at 73412 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 73412 <at> debbugs.gnu.org
Subject: Re: bug#73412: 31.0.50; Improve sql-read-product
Date: Sat, 21 Sep 2024 18:21:03 +0300

> Date: Sat, 21 Sep 2024 16:32:16 +0200
> From:  Stephen Berman via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> 0. emacs -Q
> 1. C-u M-x sql-product-interactive RET
> 
> Now the minbuffer displays the following:
> 
> SQL product: ansi
> 
> so it you want to change the product, e.g. to postgres, you first have
> to delete "ansi".
> 
> Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
> requiring deletion to change the product.
> 
> The reason "ansi" is displayed after the prompt is that the definition
> of sql-read-product uses the same non-nil value of the deprecated
> argument INITIAL-INPUT as is used for the argument DEF.  The attached
> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
> prompt argument of sql-read-product in format-prompt, so the default
> value is shown as part of the prompt and changing it does not require
> deletion.  The patch also adjusts the two callers of sql-read-product
> accordingly.

Thanks.

I think this should go to the emacs-30 branch, no?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.