GNU bug report logs - #73412
31.0.50; Improve sql-read-product

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73412 in the body.
You can then email your comments to 73412 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Improve sql-read-product
Date: Sat, 21 Sep 2024 16:32:16 +0200

[Message part 1 (text/plain, inline)]

0. emacs -Q
1. C-u M-x sql-product-interactive RET

Now the minbuffer displays the following:

SQL product: ansi

so it you want to change the product, e.g. to postgres, you first have
to delete "ansi".

Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
requiring deletion to change the product.

The reason "ansi" is displayed after the prompt is that the definition
of sql-read-product uses the same non-nil value of the deprecated
argument INITIAL-INPUT as is used for the argument DEF.  The attached
patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
prompt argument of sql-read-product in format-prompt, so the default
value is shown as part of the prompt and changing it does not require
deletion.  The patch also adjusts the two callers of sql-read-product
accordingly.


In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.43, cairo version 1.18.2) of 2024-09-12 built on strobelfssd
Repository revision: 31e8500b061b6963708e66468fc89db1006226d7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: Linux From Scratch r12.2-5-systemd

Configured using:
 'configure -C 'CFLAGS=-Og -g3''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER
WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

[Message part 2 (text/x-patch, attachment)]

Message #8 received at 73412 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 73412 <at> debbugs.gnu.org
Subject: Re: bug#73412: 31.0.50; Improve sql-read-product
Date: Sat, 21 Sep 2024 18:21:03 +0300

> Date: Sat, 21 Sep 2024 16:32:16 +0200
> From:  Stephen Berman via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> 0. emacs -Q
> 1. C-u M-x sql-product-interactive RET
> 
> Now the minbuffer displays the following:
> 
> SQL product: ansi
> 
> so it you want to change the product, e.g. to postgres, you first have
> to delete "ansi".
> 
> Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
> requiring deletion to change the product.
> 
> The reason "ansi" is displayed after the prompt is that the definition
> of sql-read-product uses the same non-nil value of the deprecated
> argument INITIAL-INPUT as is used for the argument DEF.  The attached
> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
> prompt argument of sql-read-product in format-prompt, so the default
> value is shown as part of the prompt and changing it does not require
> deletion.  The patch also adjusts the two callers of sql-read-product
> accordingly.

Thanks.

I think this should go to the emacs-30 branch, no?

Message #13 received at 73412-done <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73412-done <at> debbugs.gnu.org
Subject: Re: bug#73412: 31.0.50; Improve sql-read-product
Date: Sat, 21 Sep 2024 22:29:54 +0200

On Sat, 21 Sep 2024 18:21:03 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:

>> Date: Sat, 21 Sep 2024 16:32:16 +0200
>> From:  Stephen Berman via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>
>> 0. emacs -Q
>> 1. C-u M-x sql-product-interactive RET
>>
>> Now the minbuffer displays the following:
>>
>> SQL product: ansi
>>
>> so it you want to change the product, e.g. to postgres, you first have
>> to delete "ansi".
>>
>> Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
>> requiring deletion to change the product.
>>
>> The reason "ansi" is displayed after the prompt is that the definition
>> of sql-read-product uses the same non-nil value of the deprecated
>> argument INITIAL-INPUT as is used for the argument DEF.  The attached
>> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
>> prompt argument of sql-read-product in format-prompt, so the default
>> value is shown as part of the prompt and changing it does not require
>> deletion.  The patch also adjusts the two callers of sql-read-product
>> accordingly.
>
> Thanks.
>
> I think this should go to the emacs-30 branch, no?

I agree and did so in commit c1f2501f55d and am closing the bug.  Since
this is a minor UI update and improvement with no change in
functionality I assume it does not need to be called out in NEWS, right?

Steve Berman

Message #16 received at 73412-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 73412-done <at> debbugs.gnu.org
Subject: Re: bug#73412: 31.0.50; Improve sql-read-product
Date: Sat, 21 Sep 2024 16:51:57 -0700

Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Since this is a minor UI update and improvement with no change in
> functionality I assume it does not need to be called out in NEWS,
> right?

I don't think that's needed.

Message #19 received at 73412 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 73412 <at> debbugs.gnu.org
Subject: Re: bug#73412: 31.0.50; Improve sql-read-product
Date: Sun, 22 Sep 2024 07:45:19 +0300

> From: Stephen Berman <stephen.berman <at> gmx.net>
> Cc: 73412-done <at> debbugs.gnu.org
> Date: Sat, 21 Sep 2024 22:29:54 +0200
> 
> On Sat, 21 Sep 2024 18:21:03 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> >> Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
> >> requiring deletion to change the product.
> >>
> >> The reason "ansi" is displayed after the prompt is that the definition
> >> of sql-read-product uses the same non-nil value of the deprecated
> >> argument INITIAL-INPUT as is used for the argument DEF.  The attached
> >> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
> >> prompt argument of sql-read-product in format-prompt, so the default
> >> value is shown as part of the prompt and changing it does not require
> >> deletion.  The patch also adjusts the two callers of sql-read-product
> >> accordingly.
> >
> > Thanks.
> >
> > I think this should go to the emacs-30 branch, no?
> 
> I agree and did so in commit c1f2501f55d and am closing the bug.  Since
> this is a minor UI update and improvement with no change in
> functionality I assume it does not need to be called out in NEWS, right?

No, I don't think this warrants a NEWS item, no.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.