GNU bug report logs - #73412
31.0.50; Improve sql-read-product

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 73412 <at> debbugs.gnu.org
Subject: bug#73412: 31.0.50; Improve sql-read-product
Date: Sun, 22 Sep 2024 07:45:19 +0300

> From: Stephen Berman <stephen.berman <at> gmx.net>
> Cc: 73412-done <at> debbugs.gnu.org
> Date: Sat, 21 Sep 2024 22:29:54 +0200
> 
> On Sat, 21 Sep 2024 18:21:03 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> >> Likewise, `M-x sql-set-product RET' produces the same minbuffer display,
> >> requiring deletion to change the product.
> >>
> >> The reason "ansi" is displayed after the prompt is that the definition
> >> of sql-read-product uses the same non-nil value of the deprecated
> >> argument INITIAL-INPUT as is used for the argument DEF.  The attached
> >> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the
> >> prompt argument of sql-read-product in format-prompt, so the default
> >> value is shown as part of the prompt and changing it does not require
> >> deletion.  The patch also adjusts the two callers of sql-read-product
> >> accordingly.
> >
> > Thanks.
> >
> > I think this should go to the emacs-30 branch, no?
> 
> I agree and did so in commit c1f2501f55d and am closing the bug.  Since
> this is a minor UI update and improvement with no change in
> functionality I assume it does not need to be called out in NEWS, right?

No, I don't think this warrants a NEWS item, no.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.