GNU bug report logs - #73285
30.0.90; editorconfig-indentation-alist missing modes

Previous Next

To reply to this bug, email your comments to 73285 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Brown <brownts <at> troybrown.dev>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: 30.0.90; editorconfig-indentation-alist missing modes
Date: Sun, 15 Sep 2024 17:16:08 -0400

Recently new modes were added to the EditorConfig on GitHub, but those
modes have not made their way into Emacs' EditorConfig implementation.
I'd appreciate if the following modes could be added to the Emacs
version:
  - ada-mode
  - ada-ts-mode
  - gpr-mode
  - gpr-ts-mode

See this commit for details:
 - https://github.com/editorconfig/editorconfig-emacs/commit/7c7b1f81f8fac654791fa2b04da55edced2cef33

Message #8 received at 73285 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Troy Brown <brownts <at> troybrown.dev>
Cc: 73285 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#73285: 30.0.90; editorconfig-indentation-alist missing modes
Date: Mon, 16 Sep 2024 14:53:05 +0300

> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
> From: Troy Brown <brownts <at> troybrown.dev>
> Date: Sun, 15 Sep 2024 17:16:08 -0400
> 
> Recently new modes were added to the EditorConfig on GitHub, but those
> modes have not made their way into Emacs' EditorConfig implementation.
> I'd appreciate if the following modes could be added to the Emacs
> version:
>   - ada-mode
>   - ada-ts-mode
>   - gpr-mode
>   - gpr-ts-mode

The variable listing the modes is a defcustom, so users can update it
themselves.  We will never be able to be up-to-date with all the modes
out there that are not part of Emacs.

Stefan, any suggestions or comments?

Message #11 received at 73285 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73285 <at> debbugs.gnu.org, Troy Brown <brownts <at> troybrown.dev>
Subject: Re: bug#73285: 30.0.90; editorconfig-indentation-alist missing modes
Date: Tue, 17 Sep 2024 09:16:52 -0400

>> Recently new modes were added to the EditorConfig on GitHub, but those
>> modes have not made their way into Emacs' EditorConfig implementation.

The two code branches aren't in sync, indeed.  I'll see if I can bring
our up-to-date with the upstream code ASAP.

> The variable listing the modes is a defcustom, so users can update it
> themselves.  We will never be able to be up-to-date with all the modes
> out there that are not part of Emacs.

Indeed.  For this reason the code in Emacs (not yet upstream) introduced
`editorconfig-indent-size-vars` which is supposed to be set by the major
modes themselves.

So we should arguably change `ada/gpr(-ts)-mode` to set
`editorconfig-indent-size-vars`.


        Stefan

Message #14 received at 73285 <at> debbugs.gnu.org (full text, mbox):

From: Troy Brown <brownts <at> troybrown.dev>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 73285 <at> debbugs.gnu.org
Subject: Re: bug#73285: 30.0.90; editorconfig-indentation-alist missing modes
Date: Tue, 17 Sep 2024 18:28:44 -0400

On Tue, Sep 17, 2024 at 9:16 AM Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:
>
> >> Recently new modes were added to the EditorConfig on GitHub, but those
> >> modes have not made their way into Emacs' EditorConfig implementation.
>
> The two code branches aren't in sync, indeed.  I'll see if I can bring
> our up-to-date with the upstream code ASAP.
>
> > The variable listing the modes is a defcustom, so users can update it
> > themselves.  We will never be able to be up-to-date with all the modes
> > out there that are not part of Emacs.
>
> Indeed.  For this reason the code in Emacs (not yet upstream) introduced
> `editorconfig-indent-size-vars` which is supposed to be set by the major
> modes themselves.
>
> So we should arguably change `ada/gpr(-ts)-mode` to set
> `editorconfig-indent-size-vars`.
>

Ah, I was not aware of editorconfig-indent-size-vars.  I can update
the modes I maintain (ada-ts-mode, gpr-ts-mode) to use that instead.

Looking at editorconfig--default-indent-size-function, it looks like
if it also supported an "-ident" suffix, that would probably cover
ada-mode and gpr-mode as well.  Those modes are currently without a
maintainer, so might be good to either add them to
editorconfig-indentation-alist or to adjust the default function to
support the "-indent" suffix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.