GNU bug report logs - #73284
[PATCH] Add option to push mark after delete-pair

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73284 in the body.
You can then email your comments to 73284 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add option to push mark after delete-pair
Date: Sun, 15 Sep 2024 22:58:09 +0200

[Message part 1 (text/plain, inline)]

The delete-pair command from lisp.el deletes a matched pair of
delimiters.  After using this command, I often want to operate on the
region enclosed by the deleted delimiters.  As far as I know, there's
currently no quick way to access the end of that region.

This patch introduces a custom option, delete-pair-push-mark.  When
enabled, it causes delete-pair to push a mark at the end of the
enclosed region.

This opens up various workflows.  For instance, after deleting a pair,
we can use C-x C-x to highlight the region and act on it further.
Alternatively, we can use C-M-k to delete the first sexp inside the
delimiters, then act on the remainder.

To err on the side of caution, I hid the new behavior behind a user
option, disabled by default.  I could just as well see it being turned
on by default (or getting rid of the user option, making the new
behavior "mandatory"), and am open to suggestions/feedback.

Thanks, best,

Paul

[0001-Add-option-for-delete-pair-to-mark-end-of-region.patch (application/octet-stream, attachment)]

Message #8 received at 73284 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 73284 <at> debbugs.gnu.org
Subject: Re: bug#73284: [PATCH] Add option to push mark after delete-pair
Date: Mon, 16 Sep 2024 14:44:10 +0300

> From: Paul Nelson <ultrono <at> gmail.com>
> Date: Sun, 15 Sep 2024 22:58:09 +0200
> 
> The delete-pair command from lisp.el deletes a matched pair of
> delimiters.  After using this command, I often want to operate on the
> region enclosed by the deleted delimiters.  As far as I know, there's
> currently no quick way to access the end of that region.
> 
> This patch introduces a custom option, delete-pair-push-mark.  When
> enabled, it causes delete-pair to push a mark at the end of the
> enclosed region.
> 
> This opens up various workflows.  For instance, after deleting a pair,
> we can use C-x C-x to highlight the region and act on it further.

Shouldn't this activate the region, instead of forcing users to do
that manually?  Users that have transient-mark-mode enabled (which is
ON by default), will expect that, I think.

> To err on the side of caution, I hid the new behavior behind a user
> option, disabled by default.  I could just as well see it being turned
> on by default (or getting rid of the user option, making the new
> behavior "mandatory"), and am open to suggestions/feedback.

I don't think doing this by default is a good idea.  Such significant
changes in behavior are better off starting disabled.

Let's see what others think about such optional behavior.

Thanks.

Message #11 received at 73284 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73284 <at> debbugs.gnu.org
Subject: Re: bug#73284: [PATCH] Add option to push mark after delete-pair
Date: Mon, 16 Sep 2024 16:07:06 +0200

Thank you for the feedback.  I'll be happy to hear what others think.

> Shouldn't this activate the region, instead of forcing users to do
> that manually?  Users that have transient-mark-mode enabled (which is
> ON by default), will expect that, I think.

I've been using transient-mark-mode lately, and I actually prefer that
the proposed feature doesn't activate the region automatically, as I
don't always want to operate on the contents immediately.

But I understand your point about user expectations.  We could
accommodate both preferences by expanding the option to accept the
values nil, 'push and 'activate.

Message #14 received at 73284 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73284 <at> debbugs.gnu.org, Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#73284: [PATCH] Add option to push mark after delete-pair
Date: Tue, 17 Sep 2024 09:56:00 +0300

>> The delete-pair command from lisp.el deletes a matched pair of
>> delimiters.  After using this command, I often want to operate on the
>> region enclosed by the deleted delimiters.  As far as I know, there's
>> currently no quick way to access the end of that region.
>>
>> This patch introduces a custom option, delete-pair-push-mark.  When
>> enabled, it causes delete-pair to push a mark at the end of the
>> enclosed region.
>>
>> This opens up various workflows.  For instance, after deleting a pair,
>> we can use C-x C-x to highlight the region and act on it further.
>
> Shouldn't this activate the region, instead of forcing users to do
> that manually?  Users that have transient-mark-mode enabled (which is
> ON by default), will expect that, I think.

Please don't activate the region since this command is not related
to region selection.

>> To err on the side of caution, I hid the new behavior behind a user
>> option, disabled by default.  I could just as well see it being turned
>> on by default (or getting rid of the user option, making the new
>> behavior "mandatory"), and am open to suggestions/feedback.
>
> I don't think doing this by default is a good idea.  Such significant
> changes in behavior are better off starting disabled.
>
> Let's see what others think about such optional behavior.

I use delete-pair all the time, and sometimes indeed occurs the need
to operate on the boundaries of the deleted delimiters afterwards.
A workaround was to select the region before using delete-pair,
and for example reindent it.  But adding an easy way to do the same
after using delete-pair by pushing the mark for 'C-x C-x' would be nice.

This command doesn't use the region and I don't remember a need
to use the mark immediately before or after executing this command,
so it seems safe to push the mark without an option.

Message #17 received at 73284 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Eli Zaretskii <eliz <at> gnu.org>, Paul Nelson <ultrono <at> gmail.com>,
 73284 <at> debbugs.gnu.org
Subject: Re: bug#73284: [PATCH] Add option to push mark after delete-pair
Date: Tue, 17 Sep 2024 10:20:57 +0100

Hello,

The optional behaviour seems useful to me, and without activating the
mark, though I don't use delete-pair myself, so I'm kind of guessing.

(I have TMM turned on.)

-- 
Sean Whitton

Message #22 received at 73284-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 73284-done <at> debbugs.gnu.org
Subject: Re: bug#73284: [PATCH] Add option to push mark after delete-pair
Date: Sat, 21 Sep 2024 13:25:05 +0300

> From: Paul Nelson <ultrono <at> gmail.com>
> Date: Sun, 15 Sep 2024 22:58:09 +0200
> 
> The delete-pair command from lisp.el deletes a matched pair of
> delimiters.  After using this command, I often want to operate on the
> region enclosed by the deleted delimiters.  As far as I know, there's
> currently no quick way to access the end of that region.
> 
> This patch introduces a custom option, delete-pair-push-mark.  When
> enabled, it causes delete-pair to push a mark at the end of the
> enclosed region.
> 
> This opens up various workflows.  For instance, after deleting a pair,
> we can use C-x C-x to highlight the region and act on it further.
> Alternatively, we can use C-M-k to delete the first sexp inside the
> delimiters, then act on the remainder.
> 
> To err on the side of caution, I hid the new behavior behind a user
> option, disabled by default.  I could just as well see it being turned
> on by default (or getting rid of the user option, making the new
> behavior "mandatory"), and am open to suggestions/feedback.

Thanks, installed on master, and closing the bug.

Please in the future make sure any new user options always have the
:version tag.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.