GNU bug report logs - #73282
[PATCH] home: services: pipewire: Add utilities to profile.

Previous Next

To reply to this bug, email your comments to 73282 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <mail <at> antr.me>
To: guix-patches <at> gnu.org
Cc: paren <at> disroot.org, ludo <at> gnu.org, tanguy <at> bioneland.org, andrew <at> trop.in
Subject: [PATCH] home: services: pipewire: Add utilities to profile.
Date: Sun, 15 Sep 2024 20:19:28 +0000

* gnu/home/services/sound.scm (home-pipewire-service-type)[extensions]:
Extend home-profile-service-type to make wpctl and pw-* available in
the profile.

Change-Id: I48c1eb0798ea083acd3e1b521a24a9acdef3bf42
---
Resolves https://issues.guix.gnu.org/68565
Adds wpctl, pw-cat, and other pw- utilities to the home profile.

 gnu/home/services/sound.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/home/services/sound.scm b/gnu/home/services/sound.scm
index 313a57305b..e39ec21c81 100644
--- a/gnu/home/services/sound.scm
+++ b/gnu/home/services/sound.scm
@@ -122,7 +122,13 @@ (define home-pipewire-service-type
     (list (service-extension home-shepherd-service-type
                              home-pipewire-shepherd-services)
           (service-extension home-xdg-configuration-files-service-type
-                             home-pipewire-xdg-configuration)))
+                             home-pipewire-xdg-configuration)
+          (service-extension home-profile-service-type
+                             (lambda (config)
+                               (list
+                                (home-pipewire-configuration-pipewire config)
+                                (home-pipewire-configuration-wireplumber
+                                 config))))))
    (description
     "Start essential PipeWire services.")
    (default-value (home-pipewire-configuration))))

base-commit: ecc95ecd399ce7917a19ae3e687ea1a92caf830a
-- 
2.46.0

Message #8 received at 73282 <at> debbugs.gnu.org (full text, mbox):

From: Rutherther <rutherther <at> ditigal.xyz>
To: 73282 <at> debbugs.gnu.org
Cc: Antero Mejr <mail <at> antr.me>
Subject: Re: [PATCH] home: services: pipewire: Add utilities to profile.
Date: Wed, 30 Oct 2024 19:33:56 +0100

> Resolves https://issues.guix.gnu.org/68565
> Adds wpctl, pw-cat, and other pw- utilities to the home profile.
> 

Hi,

I think it would be at least nice to have an option that turns this off.
Why give the user the binaries, libraries to their profile if they are not actually
necessary? If one needs them, they can add them to the packages list.
It's true it's nice to have a little bit more from the service so that
it can do it for you, but it would be nice to also keep the default
behavior so that users that do not need it do not have it in their
profile unnecessarily.

Regards,
Rutherther

Message #11 received at 73282 <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <mail <at> antr.me>
To: Rutherther <rutherther <at> ditigal.xyz>
Cc: 73282 <at> debbugs.gnu.org
Subject: Re: [PATCH] home: services: pipewire: Add utilities to profile.
Date: Wed, 30 Oct 2024 18:47:09 +0000

Rutherther <rutherther <at> ditigal.xyz> writes:

>> Resolves https://issues.guix.gnu.org/68565
>> Adds wpctl, pw-cat, and other pw- utilities to the home profile.
>
> I think it would be at least nice to have an option that turns this off.
> Why give the user the binaries, libraries to their profile if they are not actually
> necessary? <snip>

I think they are necessary - if the service is running then audio will
be routed through pipewire, and if that is the case then wpctl is needed
to control the routes and volume, both essential features of an audio
server.

The pw-* utilities are mostly for recording/playback, which I think is
also important but perhaps not essential.

Message #14 received at 73282 <at> debbugs.gnu.org (full text, mbox):

From: Rutherther <rutherther <at> ditigal.xyz>
To: Antero Mejr <mail <at> antr.me>
Cc: 73282 <at> debbugs.gnu.org
Subject: Re: [PATCH] home: services: pipewire: Add utilities to profile.
Date: Wed, 30 Oct 2024 21:47:22 +0100

Antero Mejr <mail <at> antr.me> writes:

> Rutherther <rutherther <at> ditigal.xyz> writes:
>
>>> Resolves https://issues.guix.gnu.org/68565
>>> Adds wpctl, pw-cat, and other pw- utilities to the home profile.
>>
>> I think it would be at least nice to have an option that turns this off.
>> Why give the user the binaries, libraries to their profile if they are not actually
>> necessary? <snip>
>
> I think they are necessary - if the service is running then audio will
> be routed through pipewire, and if that is the case then wpctl is needed
> to control the routes and volume, both essential features of an audio
> server.
>
> The pw-* utilities are mostly for recording/playback, which I think is
> also important but perhaps not essential.

Nope, I don't have them in my profile and I can control volume and
switch outputs just fine through pavucontrol.

Regards,
Rutherther

Message #17 received at 73282 <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <mail <at> antr.me>
To: Rutherther <rutherther <at> ditigal.xyz>
Cc: 73282 <at> debbugs.gnu.org
Subject: Re: [PATCH] home: services: pipewire: Add utilities to profile.
Date: Wed, 30 Oct 2024 21:41:21 +0000

Rutherther <rutherther <at> ditigal.xyz> writes:

> Nope, I don't have them in my profile and I can control volume and
> switch outputs just fine through pavucontrol.

pavucontrol is a Pulseaudio program that operates on top of the
pipewire-pulse compatibility layer. wpctl is the native program that
interacts with the pipewire library directly.

So it would make sense to add the native packages to the profile,
because users should not be expected to have control programs for other
sound servers installed.

To put it another way: if a daemon is running that is likely to require
control commands from the user, the packages to issue those control
commands should be added to the profile.

Message #20 received at 73282 <at> debbugs.gnu.org (full text, mbox):

From: Rutherther <rutherther <at> ditigal.xyz>
To: 73282 <at> debbugs.gnu.org
Cc: Antero Mejr <mail <at> antr.me>, Rutherther <rutherther <at> ditigal.xyz>
Subject: Re: [PATCH] home: services: pipewire: Add utilities to profile.
Date: Thu, 31 Oct 2024 09:33:13 +0100

> Rutherther <rutherther <at> ditigal.xyz> writes:
> 
> > Nope, I don't have them in my profile and I can control volume and
> > switch outputs just fine through pavucontrol.
> 
> pavucontrol is a Pulseaudio program that operates on top of the
> pipewire-pulse compatibility layer. wpctl is the native program that
> interacts with the pipewire library directly.

I've just tried easyeffects, since it seems it supports
pipewire natively. I can control volume, outputs etc.
with it, without having wpctl in my profile.

> 
> So it would make sense to add the native packages to the profile,
> because users should not be expected to have control programs for other
> sound servers installed.
> 
> To put it another way: if a daemon is running that is likely to require
> control commands from the user, the packages to issue those control
> commands should be added to the profile.

I don't agree with your outcome. If it's likely user will want it,
and not necessary, there should be an easy option to turn it off/on,
not to give it to user who doesn't want it and will then have
to go hard ways to turn it off - such as modifying the service-type
itself via inheriting and removing the profile part.
The user should not be expected that they will want to use
these specific programs for controlling their audio, it's up
to them what program they choose for that and install.

Regards,
Rutherther

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.