GNU bug report logs - #73216
[PATCH 1/2] gnu: Add emacs-org-texlive-collection.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 73216 <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Ludovic Courtès <ludo <at> gnu.org>, Andrew Tropin <andrew <at> trop.in>
Subject: [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection.
Date: Fri, 13 Sep 2024 23:16:53 +0900

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

[...]

>> +(define-public emacs-org-texlive-collection
>> +  (package
>> +    (inherit emacs-org)
>> +    (name "emacs-org-texlive-collection")
>> +    (source #f)
>> +    (build-system trivial-build-system)
>> +    (arguments (list #:builder #~(mkdir #$output)))
>> +    (native-inputs '())
>> +    (inputs '())
>> +    (propagated-inputs
>> +     (list texlive-amsmath
>> +           texlive-capt-of
>> +           texlive-graphics             ;for graphicx, rotating
>> +           texlive-hyperref
>> +           texlive-titling
>> +           texlive-tools                ;for longtable
>> +           texlive-ulem
>> +           texlive-wrapfig
>> +           texlive-scheme-small))      ;for amsfonts, fontspec,
>> inputenc, etc.
> Nitpick: these comments are not aligned.

This is actually how Emacs aligns them automatically, which I tend to
stick to to avoid noise in diffs.

> As a personal thing, I also suggest using a space between ; and for,
> but I see both styles used in Guix.

A space following ';' for inline comments is actually what seems to be
our adopted convention (see "Riastradh's Lisp Style Rules",
https://mumble.net/~campbell/scheme/style.txt referenced from (info
'(guix) Formatting Code')).

I must have dreamt Ludo suggestion to drop the space at some point in
the distant past. I'll try to go back to '; comment' in my code, I
guess!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.