GNU bug report logs - #72966
30.0.90; [PATCH] php-ts-mode: custom php.ini config for the built-in php webserver

Previous Next

Full log

Message #14 received at 72966 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72966 <at> debbugs.gnu.org
Subject: Re: bug#72966: 30.0.90;
 [PATCH] php-ts-mode: custom php.ini config for the built-in php webserver
Date: Thu, 05 Sep 2024 21:16:29 +0200

[Message part 1 (text/plain, inline)]

Hi Eli, I followed your suggestion and moved the CONFIG argument. I also added 
a new entry to the NEWS file.

Thanks.
Vincenzo

In data lunedì 2 settembre 2024 16:23:53 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Date: Mon, 02 Sep 2024 15:29:23 +0200
> > 
> > Ciao,
> > this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver'
> > that allows you to specify an alternative php.ini file to the default (or
> > whatever is specified in 'php-ts-mode-php-config').
> 
> Thanks.
> 
> > -(defun php-ts-mode-run-php-webserver (&optional port hostname
> > document-root -                                               
> > router-script num-of-workers) +(defun php-ts-mode-run-php-webserver
> > (&optional port
> > +                                                hostname
> > +                                                document-root
> > +                                                router-script
> > +                                                config
> > +                                                num-of-workers)
> > 
> >    "Run PHP built-in web server.
> 
> This changes a public API in backward-incompatible way, something we
> don't do, because it could break someone's code out there.  (It is
> true that php-ts-mode was introduced in Emacs 30, but that version is
> already in pretest and will be released soon, so I don't think we can
> change this there, either.)
> 
> So please find a backward-compatible way of adding this feature,
> perhaps add the new CONFIG argument as the last one?
> 
> Also, I think this needs a NEWS entry describing the change in
> behavior.

[0001-Support-for-custom-php.ini-for-the-built-in-PHP-web-.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.