GNU bug report logs -
#72966
30.0.90; [PATCH] php-ts-mode: custom php.ini config for the built-in php webserver
Previous Next
Reported by: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Date: Mon, 2 Sep 2024 13:41:02 UTC
Severity: normal
Tags: patch
Found in version 30.0.90
Done: Eli Zaretskii <eliz <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72966 in the body.
You can then email your comments to 72966 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#72966; Package
emacs.
(Mon, 02 Sep 2024 13:41:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Vincenzo Pupillo <v.pupillo <at> gmail.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Mon, 02 Sep 2024 13:41:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ciao,
this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver' that
allows you to specify an alternative php.ini file to the default (or whatever
is specified in 'php-ts-mode-php-config').
Thanks.
Vincenzo.
[0001-Support-for-custom-php.ini-for-the-built-in-PHP-web-.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#72966; Package
emacs.
(Mon, 02 Sep 2024 14:26:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 72966 <at> debbugs.gnu.org (full text, mbox):
> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Date: Mon, 02 Sep 2024 15:29:23 +0200
>
> Ciao,
> this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver' that
> allows you to specify an alternative php.ini file to the default (or whatever
> is specified in 'php-ts-mode-php-config').
Thanks.
> -(defun php-ts-mode-run-php-webserver (&optional port hostname document-root
> - router-script num-of-workers)
> +(defun php-ts-mode-run-php-webserver (&optional port
> + hostname
> + document-root
> + router-script
> + config
> + num-of-workers)
> "Run PHP built-in web server.
This changes a public API in backward-incompatible way, something we
don't do, because it could break someone's code out there. (It is
true that php-ts-mode was introduced in Emacs 30, but that version is
already in pretest and will be released soon, so I don't think we can
change this there, either.)
So please find a backward-compatible way of adding this feature,
perhaps add the new CONFIG argument as the last one?
Also, I think this needs a NEWS entry describing the change in
behavior.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#72966; Package
emacs.
(Mon, 02 Sep 2024 14:56:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 72966 <at> debbugs.gnu.org (full text, mbox):
Ok, thanks.
I will fix ASAP.
Vincenzo.
In data lunedì 2 settembre 2024 16:23:53 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Date: Mon, 02 Sep 2024 15:29:23 +0200
> >
> > Ciao,
> > this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver'
> > that allows you to specify an alternative php.ini file to the default (or
> > whatever is specified in 'php-ts-mode-php-config').
>
> Thanks.
>
> > -(defun php-ts-mode-run-php-webserver (&optional port hostname
> > document-root -
> > router-script num-of-workers) +(defun php-ts-mode-run-php-webserver
> > (&optional port
> > + hostname
> > + document-root
> > + router-script
> > + config
> > + num-of-workers)
> >
> > "Run PHP built-in web server.
>
> This changes a public API in backward-incompatible way, something we
> don't do, because it could break someone's code out there. (It is
> true that php-ts-mode was introduced in Emacs 30, but that version is
> already in pretest and will be released soon, so I don't think we can
> change this there, either.)
>
> So please find a backward-compatible way of adding this feature,
> perhaps add the new CONFIG argument as the last one?
>
> Also, I think this needs a NEWS entry describing the change in
> behavior.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#72966; Package
emacs.
(Thu, 05 Sep 2024 19:19:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 72966 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Eli, I followed your suggestion and moved the CONFIG argument. I also added
a new entry to the NEWS file.
Thanks.
Vincenzo
In data lunedì 2 settembre 2024 16:23:53 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Date: Mon, 02 Sep 2024 15:29:23 +0200
> >
> > Ciao,
> > this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver'
> > that allows you to specify an alternative php.ini file to the default (or
> > whatever is specified in 'php-ts-mode-php-config').
>
> Thanks.
>
> > -(defun php-ts-mode-run-php-webserver (&optional port hostname
> > document-root -
> > router-script num-of-workers) +(defun php-ts-mode-run-php-webserver
> > (&optional port
> > + hostname
> > + document-root
> > + router-script
> > + config
> > + num-of-workers)
> >
> > "Run PHP built-in web server.
>
> This changes a public API in backward-incompatible way, something we
> don't do, because it could break someone's code out there. (It is
> true that php-ts-mode was introduced in Emacs 30, but that version is
> already in pretest and will be released soon, so I don't think we can
> change this there, either.)
>
> So please find a backward-compatible way of adding this feature,
> perhaps add the new CONFIG argument as the last one?
>
> Also, I think this needs a NEWS entry describing the change in
> behavior.
[0001-Support-for-custom-php.ini-for-the-built-in-PHP-web-.patch (text/x-patch, attachment)]
Reply sent
to
Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility.
(Sun, 08 Sep 2024 06:49:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Vincenzo Pupillo <v.pupillo <at> gmail.com>:
bug acknowledged by developer.
(Sun, 08 Sep 2024 06:49:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 72966-done <at> debbugs.gnu.org (full text, mbox):
> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 72966 <at> debbugs.gnu.org
> Date: Thu, 05 Sep 2024 21:16:29 +0200
>
> Hi Eli, I followed your suggestion and moved the CONFIG argument. I also added
> a new entry to the NEWS file.
Thanks, installed on the master branch, and closing the bug.
Please in the future try to adhere to our conventions of leaving two
spaces between sentences (I fixed that in this patch).
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#72966; Package
emacs.
(Sun, 08 Sep 2024 10:55:01 GMT)
Full text and
rfc822 format available.
Message #22 received at 72966-done <at> debbugs.gnu.org (full text, mbox):
In data domenica 8 settembre 2024 08:48:09 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Cc: 72966 <at> debbugs.gnu.org
> > Date: Thu, 05 Sep 2024 21:16:29 +0200
> >
> > Hi Eli, I followed your suggestion and moved the CONFIG argument. I also
> > added a new entry to the NEWS file.
>
> Thanks, installed on the master branch, and closing the bug.
>
> Please in the future try to adhere to our conventions of leaving two
> spaces between sentences (I fixed that in this patch).
Thank you Eli.
Vincenzo.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sun, 06 Oct 2024 11:24:09 GMT)
Full text and
rfc822 format available.
This bug report was last modified 313 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.