GNU bug report logs - #72871
[PATCH] gnu: Add emacs-qt-pro-mode.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72871: closed ([PATCH] gnu: Add emacs-qt-pro-mode.)
Date: Thu, 05 Sep 2024 17:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 05 Sep 2024 19:52:16 +0200
with message-id <87le06ounj.fsf <at> nicolasgoaziou.fr>
and subject line Re: [PATCH] gnu: Add emacs-qt-pro-mode.
has caused the debbugs.gnu.org bug report #72871,
regarding [PATCH] gnu: Add emacs-qt-pro-mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72871: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72871
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-qt-pro-mode.
Date: Thu, 29 Aug 2024 20:34:54 +0900

* gnu/packages/emacs-xyz.scm (emacs-qt-pro-mode): New variable.

Change-Id: I49db0f62280aa86830eb535c4b179be1bb692db4
---
 gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 79ea0955d4..5589d16d49 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14358,6 +14358,35 @@ (define-public emacs-qml-mode
 builtin JavaScript mode.")
     (license license:gpl2+)))
 
+(define-public emacs-qt-pro-mode
+  (let ((revision "0")
+        (commit "7a2da323de834294b413cbbb3c92f42f54913643"))
+    (package
+      (name "emacs-qt-pro-mode")
+      (version (git-version "1.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/emacsorphanage/qt-pro-mode")
+               (commit commit)))
+         (sha256
+          (base32 "07054hzl7gd0wfibcqvij2wx9zji330gsryn53qad9gyalvlavpa"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #t
+        #:phases #~(modify-phases %standard-phases
+                     (replace 'check
+                       (lambda* (#:key tests? #:allow-other-keys)
+                         (when tests?
+                           (invoke "make" "test")))))))
+      (home-page "https://github.com/emacsorphanage/qt-pro-mode")
+      (synopsis "Emacs major mode for Qt build-system files")
+      (description
+       "This package provides a major mode for editing Qt build-system files.")
+      (license license:gpl2+))))
+
 (define-public emacs-queue
   (package
     (name "emacs-queue")

base-commit: 09fe58e08cb1ff9be93752b018c5dd55c8ef9498
-- 
2.45.2

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 72871-done <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: Re: [PATCH] gnu: Add emacs-qt-pro-mode.
Date: Thu, 05 Sep 2024 19:52:16 +0200

Hello,

> * gnu/packages/emacs-xyz.scm (emacs-qt-pro-mode): New variable.

Thank you. I applied the patch with the following changes:

> +    (package
> +      (name "emacs-qt-pro-mode")
> +      (version (git-version "1.0.1" revision commit))

I set base version to 1.0.0, as specified in the main file. I'm not sure
where 1.0.1 is coming from.

> +       (list
> +        #:tests? #t
> +        #:phases #~(modify-phases %standard-phases
> +                     (replace 'check
> +                       (lambda* (#:key tests? #:allow-other-keys)
> +                         (when tests?
> +                           (invoke "make" "test")))))))

I replaced the whole phase with #:test-command keyword.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.