GNU bug report logs - #72768
[PATCH] Keep local keymap out of vc-git-stash-get-at-point

Previous Next

Package: emacs;

Reported by: James Thomas <jimjoe <at> gmx.net>

Date: Fri, 23 Aug 2024 05:25:02 UTC

Severity: normal

Tags: patch

Fixed in version 31.1

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72768: closed ([PATCH] Keep local keymap out of
 vc-git-stash-get-at-point)
Date: Sun, 08 Sep 2024 02:12:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 8 Sep 2024 05:11:29 +0300
with message-id <f14386da-e15e-4f5c-86a5-2e9b2956f984 <at> gutov.dev>
and subject line Re: bug#72768: [PATCH] Keep local keymap out of vc-git-stash-get-at-point
has caused the debbugs.gnu.org bug report #72768,
regarding [PATCH] Keep local keymap out of vc-git-stash-get-at-point
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72768: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72768
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: James Thomas <jimjoe <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Keep local keymap out of vc-git-stash-get-at-point
Date: Fri, 23 Aug 2024 10:53:40 +0530
[Message part 3 (text/plain, inline)]
emacs -Q
(define-key key-translation-map  [?\C-j] (kbd "RET"))
M-x vc-dir (select a git repo)
(with point on a 'stash' entry) C-x v ! = C-j (fails)

The following seems to work:

[0001-Keep-local-keymap-out-of-vc-git-stash-get-at-point.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, James Thomas <jimjoe <at> gmx.net>
Cc: 72768-done <at> debbugs.gnu.org
Subject: Re: bug#72768: [PATCH] Keep local keymap out of
 vc-git-stash-get-at-point
Date: Sun, 8 Sep 2024 05:11:29 +0300
Version: 31.1

On 07/09/2024 10:33, Eli Zaretskii wrote:
>> Date: Tue, 27 Aug 2024 03:37:54 +0530
>> From:  James Thomas via "Bug reports for GNU Emacs,
>>   the Swiss army knife of text editors"<bug-gnu-emacs <at> gnu.org>
>>
>> James Thomas wrote:
>>
>>> emacs -Q
>>> (define-key key-translation-map  [?\C-j] (kbd "RET"))
>>> M-x vc-dir (select a git repo)
>>> (with point on a 'stash' entry) C-x v ! = C-j (fails)
>> Of course, if a 'stash' doesn't exist, it may be created, so that the
>> steps are:
>>
>> emacs -Q
>> C-x C-f (open a git-tracked file, make changes), C-x C-s (and save it)
>> C-x p v (select the above repo)
>> z c (create stash)
>> M-: (define-key key-translation-map  [?\C-j] (kbd "RET"))
>> (with point on the new 'stash' entry) C-x v ! = C-j (fails)
> Dmitry, any comments or suggestions?

Makes sense. Pushed to master, thanks!


This bug report was last modified 252 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.