GNU bug report logs - #72768
[PATCH] Keep local keymap out of vc-git-stash-get-at-point

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72768 in the body.
You can then email your comments to 72768 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Keep local keymap out of vc-git-stash-get-at-point
Date: Fri, 23 Aug 2024 10:53:40 +0530

[Message part 1 (text/plain, inline)]

emacs -Q
(define-key key-translation-map  [?\C-j] (kbd "RET"))
M-x vc-dir (select a git repo)
(with point on a 'stash' entry) C-x v ! = C-j (fails)

The following seems to work:

[0001-Keep-local-keymap-out-of-vc-git-stash-get-at-point.patch (text/x-patch, attachment)]

Message #8 received at 72768 <at> debbugs.gnu.org (full text, mbox):

From: James Thomas <jimjoe <at> gmx.net>
To: 72768 <at> debbugs.gnu.org
Subject: Re: [PATCH] Keep local keymap out of vc-git-stash-get-at-point
Date: Tue, 27 Aug 2024 03:37:54 +0530

James Thomas wrote:

> emacs -Q
> (define-key key-translation-map  [?\C-j] (kbd "RET"))
> M-x vc-dir (select a git repo)
> (with point on a 'stash' entry) C-x v ! = C-j (fails)

Of course, if a 'stash' doesn't exist, it may be created, so that the
steps are:

emacs -Q
C-x C-f (open a git-tracked file, make changes), C-x C-s (and save it)
C-x p v (select the above repo)
z c (create stash)
M-: (define-key key-translation-map  [?\C-j] (kbd "RET"))
(with point on the new 'stash' entry) C-x v ! = C-j (fails)

--

Message #11 received at 72768 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: James Thomas <jimjoe <at> gmx.net>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 72768 <at> debbugs.gnu.org
Subject: Re: bug#72768: [PATCH] Keep local keymap out of
 vc-git-stash-get-at-point
Date: Sat, 07 Sep 2024 10:33:53 +0300

> Date: Tue, 27 Aug 2024 03:37:54 +0530
> From:  James Thomas via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> James Thomas wrote:
> 
> > emacs -Q
> > (define-key key-translation-map  [?\C-j] (kbd "RET"))
> > M-x vc-dir (select a git repo)
> > (with point on a 'stash' entry) C-x v ! = C-j (fails)
> 
> Of course, if a 'stash' doesn't exist, it may be created, so that the
> steps are:
> 
> emacs -Q
> C-x C-f (open a git-tracked file, make changes), C-x C-s (and save it)
> C-x p v (select the above repo)
> z c (create stash)
> M-: (define-key key-translation-map  [?\C-j] (kbd "RET"))
> (with point on the new 'stash' entry) C-x v ! = C-j (fails)

Dmitry, any comments or suggestions?

Message #16 received at 72768-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, James Thomas <jimjoe <at> gmx.net>
Cc: 72768-done <at> debbugs.gnu.org
Subject: Re: bug#72768: [PATCH] Keep local keymap out of
 vc-git-stash-get-at-point
Date: Sun, 8 Sep 2024 05:11:29 +0300

Version: 31.1

On 07/09/2024 10:33, Eli Zaretskii wrote:
>> Date: Tue, 27 Aug 2024 03:37:54 +0530
>> From:  James Thomas via "Bug reports for GNU Emacs,
>>   the Swiss army knife of text editors"<bug-gnu-emacs <at> gnu.org>
>>
>> James Thomas wrote:
>>
>>> emacs -Q
>>> (define-key key-translation-map  [?\C-j] (kbd "RET"))
>>> M-x vc-dir (select a git repo)
>>> (with point on a 'stash' entry) C-x v ! = C-j (fails)
>> Of course, if a 'stash' doesn't exist, it may be created, so that the
>> steps are:
>>
>> emacs -Q
>> C-x C-f (open a git-tracked file, make changes), C-x C-s (and save it)
>> C-x p v (select the above repo)
>> z c (create stash)
>> M-: (define-key key-translation-map  [?\C-j] (kbd "RET"))
>> (with point on the new 'stash' entry) C-x v ! = C-j (fails)
> Dmitry, any comments or suggestions?

Makes sense. Pushed to master, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.