GNU bug report logs - #72704
29.4; repunctuate-sentences ignores NO-QUERY

Previous Next

Full log

Message #89 received at 72704 <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: briandg <at> gmail.com, juri <at> linkov.net, rms <at> gnu.org, 72704 <at> debbugs.gnu.org
Subject: Re: bug#72704: 29.4; repunctuate-sentences ignores NO-QUERY
Date: Sat, 31 Aug 2024 11:50:35 -0400

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
>> Cc: briandg <at> gmail.com, rms <at> gnu.org, 72704 <at> debbugs.gnu.org,
>> juri <at> linkov.net
>> Date: Sat, 31 Aug 2024 08:19:02 -0400
>> 
>> >   Noninteractively, if optional argument NO-QUERY is non-nil, make
>> > changes
>> >   without asking for confirmation.  To achieve the same effect
>> >   interactively, press \\<query-replace-map>\\[automatic] at the
>> > first...
>> 
>> Okay!  With the attached patch, I'm content to close this issue.
>
> One minor nit:
>
>> +Noninteractively, if optional argument NO-QUERY is non-nil, make
>> changes
>> +without asking for confirmation.  You can achieve the same effect
>> +interactively, press \\<query-replace-map>\\[automatic] at the
>> first prompt to skip remaining prompts.
>                   ^^^^^
> Either "by pressing" instead of "press" or use "To achieve the same
> effect", as I proposed originally.
>
> Otherwise, LGTM, thanks.

Good catch, thanks!

Joseph

[0001-Clarify-skipping-prompts-in-repunctuate-sentences-do.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.