GNU bug report logs - #72703
[PATCH] gnu: gtk+-2: Disable UI tests.

Previous Next

To reply to this bug, email your comments to 72703 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Frederickson <jonathan <at> terracrypt.net>
To: guix-patches <at> gnu.org
Cc: Jonathan Frederickson <jonathan <at> terracrypt.net>
Subject: [PATCH] gnu: gtk+-2: Disable UI tests.
Date: Sun, 18 Aug 2024 17:14:48 -0400

* gnu/packages/gtk.scm (gtk+-2): Disable ui-tests. They seem to be flaky on
aarch64, and I haven't been able to get the package to build without this
change.

Change-Id: I5aa5a89a2874ad1c737cba16c3aaeedced606de3
---
 gnu/packages/gtk.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 04183fa806..a0da976fab 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -980,6 +980,9 @@ (define-public gtk+-2
                 (("g_test_add_func \\(\"/recent-manager.*;") ""))
               (substitute* "gtk/tests/defaultvalue.c"
                 (("return g_test_run\\(\\);") ""))
+              ;; UI tests seem to be flaky on aarch64
+              (substitute* "gtk/tests/testing.c"
+                (("g_test_add_func \\(\"/ui-tests.*;") ""))
               ;; These require XPM support in Gdk-Pixbuf which is obsolete.
               (substitute* "gtk/tests/textbuffer.c"
                 (("g_test_add_func.*test_fill_empty\\);")

base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
-- 
2.45.2

Message #8 received at 72703 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Jonathan Frederickson <jonathan <at> terracrypt.net>, 72703 <at> debbugs.gnu.org
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#72703] [PATCH] gnu: gtk+-2: Disable UI tests.
Date: Sun, 18 Aug 2024 23:38:17 +0200

Am Sonntag, dem 18.08.2024 um 17:14 -0400 schrieb Jonathan
Frederickson:
> * gnu/packages/gtk.scm (gtk+-2): Disable ui-tests. They seem to be
> flaky on aarch64, and I haven't been able to get the package to build
> without this change.
> 
> Change-Id: I5aa5a89a2874ad1c737cba16c3aaeedced606de3
> ---
Given that gtk+-2 is fairly lowlevel package, you might want to wrap
this snippet so that only applies to arches where it's known to be
flaky.

Cheers

Message #11 received at 72703 <at> debbugs.gnu.org (full text, mbox):

From: "Jonathan Frederickson" <jonathan <at> terracrypt.net>
To: "Liliana Marie Prikler" <liliana.prikler <at> gmail.com>, 72703 <at> debbugs.gnu.org
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#72703] [PATCH] gnu: gtk+-2: Disable UI tests.
Date: Sun, 18 Aug 2024 18:57:21 -0400

On Sun, Aug 18, 2024, at 5:38 PM, Liliana Marie Prikler wrote:
> Given that gtk+-2 is fairly lowlevel package, you might want to wrap
> this snippet so that only applies to arches where it's known to be
> flaky.

Ah, good point - I'll try and work out how to do this, and send an updated patch soon.

Message #14 received at 72703 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Frederickson <jonathan <at> terracrypt.net>
To: 72703 <at> debbugs.gnu.org
Cc: Jonathan Frederickson <jonathan <at> terracrypt.net>
Subject: [PATCH v2] gnu: gtk+-2: Disable UI tests on aarch64.
Date: Mon, 19 Aug 2024 19:44:11 -0400

* gnu/packages/gtk.scm (gtk+-2): Disable ui-tests on aarch64. They seem to be
flaky on aarch64, and I haven't been able to get the package to build without
this change.

Change-Id: I5aa5a89a2874ad1c737cba16c3aaeedced606de3
---
 gnu/packages/gtk.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 04183fa806..667e0d4dbf 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -980,6 +980,12 @@ (define-public gtk+-2
                 (("g_test_add_func \\(\"/recent-manager.*;") ""))
               (substitute* "gtk/tests/defaultvalue.c"
                 (("return g_test_run\\(\\);") ""))
+              ;; UI tests seem to be flaky on aarch64
+              #$@(if (string=? (%current-system) "aarch64-linux")
+                     (list
+                      #~(substitute* "gtk/tests/testing.c"
+                          (("g_test_add_func \\(\"/ui-tests.*;") "")))
+                     #~())
               ;; These require XPM support in Gdk-Pixbuf which is obsolete.
               (substitute* "gtk/tests/textbuffer.c"
                 (("g_test_add_func.*test_fill_empty\\);")

base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
-- 
2.45.2

Message #17 received at 72703 <at> debbugs.gnu.org (full text, mbox):

From: "Jonathan Frederickson" <jonathan <at> terracrypt.net>
To: 72703 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: gtk+-2: Disable UI tests on aarch64.
Date: Mon, 19 Aug 2024 19:53:56 -0400

[Message part 1 (text/plain, inline)]

Alright, I think I got it, though I'll admit to being a bit unfamiliar with g-expressions. My primary laptop is aarch64, but I have an x86_64 server set up for build offloads. I ran a 'guix build --system=x86_64-linux' on the commits before and after and it didn't seem to trigger a rebuild, which is good.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.