GNU bug report logs - #72704
29.4; repunctuate-sentences ignores NO-QUERY

Previous Next

Full log

View this message in rfc822 format

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: briandg <at> gmail.com, juri <at> linkov.net, rms <at> gnu.org, 72704 <at> debbugs.gnu.org
Subject: bug#72704: 29.4; repunctuate-sentences ignores NO-QUERY
Date: Sat, 31 Aug 2024 08:19:02 -0400

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
>> Cc: Brian Green <briandg <at> gmail.com>,  rms <at> gnu.org,  72704 <at> debbugs.gnu.org,
>>   juri <at> linkov.net
>> Date: Sat, 24 Aug 2024 10:09:10 -0700
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: Brian Green <briandg <at> gmail.com>
>> >> Date: Sat, 24 Aug 2024 01:29:11 -0700
>> >> Cc: Eli Zaretskii <eliz <at> gnu.org>, rms <at> gnu.org, 72704 <at> debbugs.gnu.org, juri <at> linkov.net
>> >> 
>> >> I submitted this "bug" report because I mis-interpreted the docstring,
>> >> and because I was approaching this command with a preconceived idea
>> >> about how it should work.  I think Eli is right.  I can't think of a
>> >> good reason why I would need to stipulate a certain behavior before
>> >> calling the command which I can already get at any point while the
>> >> command is running.
>> >
>> > The doc string indeed could use some improvements, at least in stating
>> > explicitly what happens in interactive usage and what only when called
>> > from Lisp.
>> 
>> See patch.  Is the text wrapping acceptable?  It looks too long in
>> paragraphs.el but good in the *Help* buffer.
>
> Is this instead of the code change or in addition to it?

Instead.

> In any case, I think it would be better to say
>
>   Noninteractively, if optional argument NO-QUERY is non-nil, make changes
>   without asking for confirmation.  To achieve the same effect
>   interactively, press \\<query-replace-map>\\[automatic] at the first...

Okay!  With the attached patch, I'm content to close this issue.

[0001-Clarify-skipping-prompts-in-repunctuate-sentences-do.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.