GNU bug report logs - #72704
29.4; repunctuate-sentences ignores NO-QUERY

Previous Next

Package: emacs;

Reported by: Brian Green <briandg <at> gmail.com>

Date: Sun, 18 Aug 2024 22:50:02 UTC

Severity: normal

Found in version 29.4

Full log


View this message in rfc822 format

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Richard Stallman <rms <at> gnu.org>
Cc: briandg <at> gmail.com, 72704 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#72704: 29.4; repunctuate-sentences ignores NO-QUERY
Date: Fri, 23 Aug 2024 23:30:52 -0700
[Message part 1 (text/plain, inline)]
Richard Stallman <rms <at> gnu.org> writes:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
> The usual default behavior of Emacs commands that take START and END
> arguments is to operate by default on the reguon.
> `repunctuate-sentences' operates by default from point to EOB.  Is
> that wise?  Is there a reason why it should not follow
> the usual convention instead?

AFAICT, `repunctuate-sentences' does operate on the region when active:

(interactive (list nil (use-region-beginning) (use-region-end)))

Please see the attached patch, which makes repunctuate-sentences respect
the current prefix argument.

Juri, do I need to update the interactive-args declaration?  I'm not
totally clear on how that works.

Thank you!

Joseph

[0001-Interpret-prefix-argument-as-NO-QUERY-in-repunctuate.patch (text/x-diff, attachment)]

This bug report was last modified 289 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.