GNU bug report logs - #72666
[PATCH] Add firefly-synth package

Previous Next

Full log

View this message in rfc822 format

From: Steve George <steve <at> futurile.net>
To: 72666 <at> debbugs.gnu.org
Subject: [bug#72666] Add firely-synth package to Guix
Date: Thu, 31 Oct 2024 10:54:33 +0000

Hi,

You sent a patch to add firefly-synth, a couple of things:

1. Looks like there's a new release, can you update the patch?
  https://github.com/sjoerdvankreel/firefly-synth/releases/tag/v1.9.6

2. You added it to the end of music.scm please don't put it there as it makes
diffs more difficult. See if there's an alphabetical location in the file if at all possible.

3. Please send patches 'in-line' so that the automated QA system can pick them up.
I think the manual now has an updated section on how to use git send-email which might help.

https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

Thanks,

Futurile

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.