GNU bug report logs - #72665
[PATCH] Add bitrot-plugins package

Previous Next

To reply to this bug, email your comments to 72665 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Apoorv <apoorvs <at> tuta.io>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] Add bitrot-plugins package
Date: Fri, 16 Aug 2024 12:42:48 +0200 (CEST)

[Message part 1 (text/plain, inline)]

This is a patch to add a new package, `bitrot-plugins` to `gnu/packages/music.scm`.

-- 
 Sent with Tuta; enjoy secure & ad-free emails: 
 https://tuta.com

[Message part 2 (text/html, inline)]

[0012-Add-bitrot-plugins-package.patch (text/x-patch, attachment)]

Message #8 received at 72665 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Apoorv <apoorvs <at> tuta.io>
Cc: 72665 <at> debbugs.gnu.org
Subject: Re: [bug#72665] [PATCH] Add bitrot-plugins package
Date: Tue, 04 Feb 2025 18:26:33 +0800

Apoorv <apoorvs <at> tuta.io> writes:

> From: apoorv569 <apoorvs569 <at> gmail.com>
> Date: Fri, 16 Aug 2024 15:36:25 +0530
> Subject: [PATCH 12/13] Add bitrot-plugins package
>
> ---
>  gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index d3e247bd10..5b89419b07 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -8549,6 +8549,34 @@ (define-public ykchorus
>  well-known Japanese vintage analog synthesizers (You Know which).")
>       (license license:gpl2))))
>  
> +(define-public bitrot-plugins
> +  (let ((commit "06a72cd6cbe99b469e57a662cfb34e1cfe75e070")
> +        (revision "0"))
> +    (package
> +     (name "bitrot-plugins")
> +     (version (git-version "0.7" revision commit))
> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/grejppi/bitrot")
> +             (recursive? #t)
> +             (commit commit)))

I see there are some packages you sent both use DPF, can we build it as
a shared library and unbundle DPF in each plugin package?

> +       (sha256
> +        (base32 "0gfhy6a1cc8czrw2bq922b87584fbzpvwdzrl0vv3acda03z1f85"))
> +       (file-name (git-file-name name version))))
> +     (build-system waf-build-system)
> +     (arguments
> +      `(#:configure-flags (list "--platform=linux64")

Is this 'platform' argument actually needed?  Not tried, but I think
it's for cross-compile, and when not specified it should default to
current one..

> +        #:phases (modify-phases %standard-phases
> +                                ;; no check target
> +                                (delete 'check))))
> +     (home-page "https://github.com/grejppi/bitrot")
> +     (synopsis "Audio effect plugins (LV2, VST2, LADSPA) for glitch effects")
> +     (description
> +      "Audio effect plugins (LV2, VST2, LADSPA) for glitch effects")

Description should be a full sentence, ends with period.

Message #11 received at 72665 <at> debbugs.gnu.org (full text, mbox):

From: Apoorv <apoorvs <at> tuta.io>
To: 72665 <72665 <at> debbugs.gnu.org>
Subject: RE: Add bitrot-plugins package
Date: Sat, 15 Mar 2025 19:32:36 +0100 (CET)

[Message part 1 (text/plain, inline)]

Here is the updated patch.

I could try to make dpf a separate package but pretty much every package that uses dpf as a submodule uses a different version/commit of it.
-- 
 Secured with Tuta Mail: 
 https://tuta.com/free-email

[Message part 2 (text/html, inline)]

[0001-Add-bitrot-plugins-package.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.