GNU bug report logs - #72540
[PATCH] gnu: xmonad: Re-add xmonad.desktop file

Previous Next

Package: guix-patches;

Reported by: Saku Laesvuori <saku <at> laesvuori.fi>

Date: Fri, 9 Aug 2024 11:51:01 UTC

Severity: normal

Tags: patch

Merged with 72538

Done: Lars-Dominik Braun <lars <at> 6xq.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72540 in the body.
You can then email your comments to 72540 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#72540; Package guix-patches. (Fri, 09 Aug 2024 11:51:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Saku Laesvuori <saku <at> laesvuori.fi>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 09 Aug 2024 11:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Saku Laesvuori <saku <at> laesvuori.fi>
To: guix-patches <at> gnu.org
Cc: Saku Laesvuori <saku <at> laesvuori.fi>
Subject: [PATCH] gnu: xmonad: Re-add xmonad.desktop file
Date: Fri,  9 Aug 2024 14:49:00 +0300
* gnu/packages/wm.scm (xmonad)[arguments]: Re-add 'install-xsession phase
  to enable starting xmonad from a display manager.

Change-Id: I8b29e5a44e9b7a47256a5115e36fb7ff6e0e471a
---
 gnu/packages/wm.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ad74fb5cf7..7ebed1fd67 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -874,6 +874,23 @@ (define-public xmonad
     (properties '((upstream-name . "xmonad")))
     (inputs (list ghc-x11 ghc-data-default-class ghc-setlocale))
     (native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
+    (arguments
+      (list
+       #:phases
+       #~(modify-phases %standard-phases
+           (add-after 'install 'install-xsession
+             (lambda _
+               (let ((xsessions (string-append #$output "/share/xsessions")))
+                 (mkdir-p xsessions)
+                 (call-with-output-file (string-append xsessions
+                                                       "/xmonad.desktop")
+                  (lambda (port)
+                    (format port "~
+                     [Desktop Entry]~@
+                     Name=~a~@
+                     Comment=xmonad window manager~@
+                     Exec=~a/bin/xmonad~@
+                     Type=Application~%" #$name #$output)))))))))
     (home-page "http://xmonad.org")
     (synopsis "Tiling window manager")
     (description

base-commit: 20dbf225f332ccc707578263ed710dcf2a8fb78e
-- 
2.45.2





Information forwarded to guix-patches <at> gnu.org:
bug#72540; Package guix-patches. (Fri, 09 Aug 2024 12:19:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Saku Laesvuori via Guix-patches via <guix-patches <at> gnu.org>
Cc: Saku Laesvuori <saku <at> laesvuori.fi>, 72540 <at> debbugs.gnu.org
Subject: Re: [bug#72540] [PATCH] gnu: xmonad: Re-add xmonad.desktop file
Date: Fri, 09 Aug 2024 20:17:20 +0800
[Message part 1 (text/plain, inline)]
Saku Laesvuori via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/wm.scm (xmonad)[arguments]: Re-add 'install-xsession phase
>   to enable starting xmonad from a display manager.
>
> Change-Id: I8b29e5a44e9b7a47256a5115e36fb7ff6e0e471a
> ---
>  gnu/packages/wm.scm | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index ad74fb5cf7..7ebed1fd67 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -874,6 +874,23 @@ (define-public xmonad
>      (properties '((upstream-name . "xmonad")))
>      (inputs (list ghc-x11 ghc-data-default-class ghc-setlocale))
>      (native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
> +    (arguments
> +      (list
> +       #:phases
> +       #~(modify-phases %standard-phases
> +           (add-after 'install 'install-xsession
> +             (lambda _
> +               (let ((xsessions (string-append #$output "/share/xsessions")))
> +                 (mkdir-p xsessions)
> +                 (call-with-output-file (string-append xsessions
> +                                                       "/xmonad.desktop")
> +                  (lambda (port)
> +                    (format port "~
> +                     [Desktop Entry]~@
> +                     Name=~a~@
> +                     Comment=xmonad window manager~@
> +                     Exec=~a/bin/xmonad~@
> +                     Type=Application~%" #$name #$output)))))))))

i think can use `make-desktop-entry-file'

>      (home-page "http://xmonad.org")
>      (synopsis "Tiling window manager")
>      (description
>
> base-commit: 20dbf225f332ccc707578263ed710dcf2a8fb78e
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#72540; Package guix-patches. (Fri, 09 Aug 2024 12:19:02 GMT) Full text and rfc822 format available.

Merged 72538 72540. Request was from Lars-Dominik Braun <lars <at> 6xq.net> to control <at> debbugs.gnu.org. (Sat, 10 Aug 2024 08:51:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 23 Sep 2024 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 327 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.