GNU bug report logs - #72521
[PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72521: closed ([PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode)
Date: Thu, 08 Aug 2024 10:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 08 Aug 2024 13:34:00 +0300
with message-id <86cymjmhgn.fsf <at> gnu.org>
and subject line Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
has caused the debbugs.gnu.org bug report #72521,
regarding [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72521: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72521
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
Date: Thu, 8 Aug 2024 12:25:18 +1000

[Message part 3 (text/plain, inline)]

> On 8 Aug 2024, at 12:18, Paul W. Rankin <rnkn <at> rnkn.xyz> wrote:
> 
> This is currently hard-coded and should instead be implemented as a 
> user option, probably a hook, but this is outside the scope of this 
> patch.
> 
> <0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch>

Patched instead against current master.

[0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
Cc: 72521-done <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 08 Aug 2024 13:34:00 +0300

> From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
> Date: Thu, 8 Aug 2024 19:57:18 +1000
> Cc: 72521 <at> debbugs.gnu.org
> 
> > On 8 Aug 2024, at 19:45, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > Looks good, but I wonder whether a simple boolean user option would be
> > better, and also easier to customize.  After all this is not a mode,
> > so people will not expect it to have a hook.  Also, if someone doesn't
> > want variable-pitch-mode, I doubt they will want some other mode
> > instead, so the hook will most of the time be or the default or nil.
> > 
> > WDYT?
> 
> Agreed. I’ve added `help-for-help-use-variable-pitch’ boolean option. 
> Although it’s a mouthful, I think this name is most discoverable since 
> C-h C-k C-h C-h returns `help-for-help’, and there’s variable 
> `help-for-help-buffer-name’.

Thanks, installed on the emacs-30 release branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.