GNU bug report logs - #72521
[PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72521 in the body.
You can then email your comments to 72521 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
Date: Thu, 8 Aug 2024 12:25:18 +1000

[Message part 1 (text/plain, inline)]

> On 8 Aug 2024, at 12:18, Paul W. Rankin <rnkn <at> rnkn.xyz> wrote:
> 
> This is currently hard-coded and should instead be implemented as a 
> user option, probably a hook, but this is outside the scope of this 
> patch.
> 
> <0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch>

Patched instead against current master.

[0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch (application/octet-stream, attachment)]

Message #8 received at 72521 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
Cc: 72521 <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 08 Aug 2024 11:58:09 +0300

> Date: Thu, 8 Aug 2024 12:25:18 +1000
> From:  "Paul W. Rankin" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> > On 8 Aug 2024, at 12:18, Paul W. Rankin <rnkn <at> rnkn.xyz> wrote:
> > 
> > This is currently hard-coded and should instead be implemented as a 
> > user option, probably a hook, but this is outside the scope of this 
> > patch.
> > 
> > <0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch>
> 
> Patched instead against current master.

Thanks, but we cannot possible install this patch, since this behavior
was introduced in Emacs 29.  I agree with making this feature
optional, of course (and it will then be ON by default), but your
patch doesn't do that.

Message #11 received at 72521 <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72521 <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 8 Aug 2024 19:37:22 +1000

> On 8 Aug 2024, at 18:58, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> Thanks, but we cannot possible install this patch, since this behavior
> was introduced in Emacs 29.  I agree with making this feature
> optional, of course (and it will then be ON by default), but your
> patch doesn't do that.

Hi Eli,

Thanks. I’ve replaced the call to variable-pitch-mode with a hook, 
help-screen-hook, which defaults to calling variable-pitch-mode.

Ideally I think this should just be help-mode-hook though, which of 
course should not default to calling variable-pitch-mode.

Anyway, how’s the patch look to you?

Message #14 received at 72521 <at> debbugs.gnu.org (full text, mbox):

From: Paul W. Rankin <rnkn <at> rnkn.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72521 <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 8 Aug 2024 19:37:56 +1000

[Message part 1 (text/plain, inline)]

> On 8 Aug 2024, at 18:58, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> Thanks, but we cannot possible install this patch, since this behavior
> was introduced in Emacs 29.  I agree with making this feature
> optional, of course (and it will then be ON by default), but your
> patch doesn't do that.

Hi Eli,

Thanks. I’ve replaced the call to variable-pitch-mode with a hook, 
help-screen-hook, which defaults to calling variable-pitch-mode.

Ideally I think this should just be help-mode-hook though, which of 
course should not default to calling variable-pitch-mode.

Anyway, how’s the patch (now attached) look to you?

[0001-lisp-help-macro.el-add-help-screen-hook.patch (application/octet-stream, attachment)]

Message #17 received at 72521 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul W. Rankin <rnkn <at> rnkn.xyz>
Cc: 72521 <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 08 Aug 2024 12:45:02 +0300

> From: Paul W. Rankin <rnkn <at> rnkn.xyz>
> Date: Thu, 8 Aug 2024 19:37:56 +1000
> Cc: 72521 <at> debbugs.gnu.org
> 
> > On 8 Aug 2024, at 18:58, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > Thanks, but we cannot possible install this patch, since this behavior
> > was introduced in Emacs 29.  I agree with making this feature
> > optional, of course (and it will then be ON by default), but your
> > patch doesn't do that.
> 
> Hi Eli,
> 
> Thanks. I’ve replaced the call to variable-pitch-mode with a hook, 
> help-screen-hook, which defaults to calling variable-pitch-mode.
> 
> Ideally I think this should just be help-mode-hook though, which of 
> course should not default to calling variable-pitch-mode.
> 
> Anyway, how’s the patch (now attached) look to you?

Looks good, but I wonder whether a simple boolean user option would be
better, and also easier to customize.  After all this is not a mode,
so people will not expect it to have a hook.  Also, if someone doesn't
want variable-pitch-mode, I doubt they will want some other mode
instead, so the hook will most of the time be or the default or nil.

WDYT?

Message #20 received at 72521 <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72521 <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 8 Aug 2024 19:57:18 +1000

[Message part 1 (text/plain, inline)]

> On 8 Aug 2024, at 19:45, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> Looks good, but I wonder whether a simple boolean user option would be
> better, and also easier to customize.  After all this is not a mode,
> so people will not expect it to have a hook.  Also, if someone doesn't
> want variable-pitch-mode, I doubt they will want some other mode
> instead, so the hook will most of the time be or the default or nil.
> 
> WDYT?

Agreed. I’ve added `help-for-help-use-variable-pitch’ boolean option. 
Although it’s a mouthful, I think this name is most discoverable since 
C-h C-k C-h C-h returns `help-for-help’, and there’s variable 
`help-for-help-buffer-name’.

[0001-lisp-help-macro.el-add-help-for-help-use-variable-pi.patch (application/octet-stream, attachment)]

Message #25 received at 72521-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
Cc: 72521-done <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 08 Aug 2024 13:34:00 +0300

> From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
> Date: Thu, 8 Aug 2024 19:57:18 +1000
> Cc: 72521 <at> debbugs.gnu.org
> 
> > On 8 Aug 2024, at 19:45, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > Looks good, but I wonder whether a simple boolean user option would be
> > better, and also easier to customize.  After all this is not a mode,
> > so people will not expect it to have a hook.  Also, if someone doesn't
> > want variable-pitch-mode, I doubt they will want some other mode
> > instead, so the hook will most of the time be or the default or nil.
> > 
> > WDYT?
> 
> Agreed. I’ve added `help-for-help-use-variable-pitch’ boolean option. 
> Although it’s a mouthful, I think this name is most discoverable since 
> C-h C-k C-h C-h returns `help-for-help’, and there’s variable 
> `help-for-help-buffer-name’.

Thanks, installed on the emacs-30 release branch, and closing the bug.

Message #28 received at 72521-done <at> debbugs.gnu.org (full text, mbox):

From: "Paul W. Rankin" <rnkn <at> rnkn.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72521-done <at> debbugs.gnu.org
Subject: Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded
 variable-pitch-mode
Date: Thu, 8 Aug 2024 20:34:46 +1000

> On 8 Aug 2024, at 20:34, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> Thanks, installed on the emacs-30 release branch, and closing the bug.

Thanks :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.