GNU bug report logs - #72521
[PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode

Previous Next

Package: emacs;

Reported by: "Paul W. Rankin" <rnkn <at> rnkn.xyz>

Date: Thu, 8 Aug 2024 07:32:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul W. Rankin <rnkn <at> rnkn.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72521 <at> debbugs.gnu.org
Subject: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
Date: Thu, 8 Aug 2024 19:37:56 +1000
[Message part 1 (text/plain, inline)]
> On 8 Aug 2024, at 18:58, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> Thanks, but we cannot possible install this patch, since this behavior
> was introduced in Emacs 29.  I agree with making this feature
> optional, of course (and it will then be ON by default), but your
> patch doesn't do that.

Hi Eli,

Thanks. I’ve replaced the call to variable-pitch-mode with a hook, 
help-screen-hook, which defaults to calling variable-pitch-mode.

Ideally I think this should just be help-mode-hook though, which of 
course should not default to calling variable-pitch-mode.

Anyway, how’s the patch (now attached) look to you?

[0001-lisp-help-macro.el-add-help-screen-hook.patch (application/octet-stream, attachment)]

This bug report was last modified 338 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.