GNU bug report logs - #72465
[PATCH 1/2] Document how set path to C source code for SUSE based systems

Previous Next

Full log

Message #14 received at 72465 <at> debbugs.gnu.org (full text, mbox):

From: Björn Bidar <bjorn.bidar <at> thaodan.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72465 <at> debbugs.gnu.org
Subject: Re: bug#72465: [PATCH 1/2] Document how set path to C source code
 for SUSE based systems
Date: Sun, 04 Aug 2024 19:39:36 +0300

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sun, 4 Aug 2024 16:09:36 +0300
>> From:  Björn Bidar via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> * etc/PROBLEMS(Problems when reading or debugging Emacs C code):
>> Document how to install Emacs C source and how to set path it for SUSE
>> based distributions such as openSUSE and SUSE Linux Enterprise.
>> ---
>>  etc/PROBLEMS | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>
> Thanks, I installed this on the emacs-30 branch, after some
> reformatting and minor editing.
>
> Please in the future try to conform to our conventions regarding
> maximum line length in commit log messages, and other minor formatting
> nits.

I had trouble keeping the change in line the the summary part of the
message.

Similar for the line length in the file itself. Now reading the file
again it seems obvious I will do better next time.

> In addition, please don't submit patches of a series as separate
> messages with separate and different Subject lines, because then the
> bug tracker creates a separate bug report from each message you send.
> Instead, attach them all as separate attachments to a single email
> message and send it only once.  (And in general, we here prefer that
> patches that constitute a single coherent changeset not be broken into
> several patches, but instead submitted as a single patch: that makes
> the review simpler.)

From my point of view using the patch as the email message directly
allows reviewing it inline much easier than a file where you can't
really do that. Plus reading the manual and etc/CONTRIBUTE was confusing
as they didn't say exactly the same. E.g. the manual didn't say anything
that you prefer git patches as attachment, which is uncommon from other
projects I know so far.

That I send three messages in a row like this was my lack oversight  on how
debbugs works which I should have known already.

As you can see I tried to follow the conventions.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.