GNU bug report logs - #72465
[PATCH 1/2] Document how set path to C source code for SUSE based systems

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72465 in the body.
You can then email your comments to 72465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Bidar <bjorn.bidar <at> thaodan.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH 1/2] Document how set path to C source code for SUSE based
 systems
Date: Sun, 4 Aug 2024 16:09:36 +0300

* etc/PROBLEMS(Problems when reading or debugging Emacs C code):
Document how to install Emacs C source and how to set path it for SUSE
based distributions such as openSUSE and SUSE Linux Enterprise.
---
 etc/PROBLEMS | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/etc/PROBLEMS b/etc/PROBLEMS
index c1ad8321fa6..ef205da2c17 100644
--- a/etc/PROBLEMS
+++ b/etc/PROBLEMS
@@ -456,6 +456,25 @@ However, the exact directory name will depend on the system, and you
 will need to both upgrade source and debug info when your system
 upgrades or patches Emacs, and change your startup file accordingly.
 
+** SUSE based distributions (openSUSE, SUSE Linux Enterprise)
+
+On systems with distributions, you can install source and debug info
+via superuser commands like the following:
+
+    # Install Emacs source and debuginfo by using --plus-content
+    zypper --plus-content debug,source install emacs-debuginfo emacs-debugsource
+
+To get describe-function and similar commands to work, you can then
+add something like the following to your startup file:
+
+    (setq find-function-C-source-directory
+          (car (file-expand-wildcards "/usr/src/debug/emacs-*/src")))
+
+The line above should work for all systems using zypper besides SUSE
+based ones, however it could be that you have to adjust the path to
+the sources slightly depending on the version of the distribution you
+have installed.
+
 ** Source and debuginfo for other systems
 
 If your system follows neither the Debian nor the Red Hat patterns,
-- 
2.45.2

Message #8 received at 72465 <at> debbugs.gnu.org (full text, mbox):

From: Björn Bidar <bjorn.bidar <at> thaodan.de>
To: 72465 <at> debbugs.gnu.org
Subject: Re: bug#72465: Acknowledgement ([PATCH 1/2] Document how set path
 to C source code for SUSE based systems)
Date: Sun, 04 Aug 2024 19:24:54 +0300

Sorry I meant to send the patches in a reply to the the cover message.
Please close the bug I created by accident.

Message #11 received at 72465 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Björn Bidar <bjorn.bidar <at> thaodan.de>
Cc: 72465 <at> debbugs.gnu.org
Subject: Re: bug#72465: [PATCH 1/2] Document how set path to C source code for
 SUSE based systems
Date: Sun, 04 Aug 2024 19:28:45 +0300

> Date: Sun, 4 Aug 2024 16:09:36 +0300
> From:  Björn Bidar via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> * etc/PROBLEMS(Problems when reading or debugging Emacs C code):
> Document how to install Emacs C source and how to set path it for SUSE
> based distributions such as openSUSE and SUSE Linux Enterprise.
> ---
>  etc/PROBLEMS | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

Thanks, I installed this on the emacs-30 branch, after some
reformatting and minor editing.

Please in the future try to conform to our conventions regarding
maximum line length in commit log messages, and other minor formatting
nits.

In addition, please don't submit patches of a series as separate
messages with separate and different Subject lines, because then the
bug tracker creates a separate bug report from each message you send.
Instead, attach them all as separate attachments to a single email
message and send it only once.  (And in general, we here prefer that
patches that constitute a single coherent changeset not be broken into
several patches, but instead submitted as a single patch: that makes
the review simpler.)

Thanks.

Message #14 received at 72465 <at> debbugs.gnu.org (full text, mbox):

From: Björn Bidar <bjorn.bidar <at> thaodan.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72465 <at> debbugs.gnu.org
Subject: Re: bug#72465: [PATCH 1/2] Document how set path to C source code
 for SUSE based systems
Date: Sun, 04 Aug 2024 19:39:36 +0300

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sun, 4 Aug 2024 16:09:36 +0300
>> From:  Björn Bidar via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> * etc/PROBLEMS(Problems when reading or debugging Emacs C code):
>> Document how to install Emacs C source and how to set path it for SUSE
>> based distributions such as openSUSE and SUSE Linux Enterprise.
>> ---
>>  etc/PROBLEMS | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>
> Thanks, I installed this on the emacs-30 branch, after some
> reformatting and minor editing.
>
> Please in the future try to conform to our conventions regarding
> maximum line length in commit log messages, and other minor formatting
> nits.

I had trouble keeping the change in line the the summary part of the
message.

Similar for the line length in the file itself. Now reading the file
again it seems obvious I will do better next time.

> In addition, please don't submit patches of a series as separate
> messages with separate and different Subject lines, because then the
> bug tracker creates a separate bug report from each message you send.
> Instead, attach them all as separate attachments to a single email
> message and send it only once.  (And in general, we here prefer that
> patches that constitute a single coherent changeset not be broken into
> several patches, but instead submitted as a single patch: that makes
> the review simpler.)

From my point of view using the patch as the email message directly
allows reviewing it inline much easier than a file where you can't
really do that. Plus reading the manual and etc/CONTRIBUTE was confusing
as they didn't say exactly the same. E.g. the manual didn't say anything
that you prefer git patches as attachment, which is uncommon from other
projects I know so far.

That I send three messages in a row like this was my lack oversight  on how
debbugs works which I should have known already.

As you can see I tried to follow the conventions.

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Björn Bidar via "Bug reports for GNU Emacs, the Swiss
 army knife of text editors" <bug-gnu-emacs <at> gnu.org>
Cc: Björn Bidar <bjorn.bidar <at> thaodan.de>,
 72465-done <at> debbugs.gnu.org
Subject: Re: bug#72465: Acknowledgement ([PATCH 1/2] Document how set path
 to C source code for SUSE based systems)
Date: Mon, 05 Aug 2024 05:46:47 -0400

Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> Sorry I meant to send the patches in a reply to the the cover message.
> Please close the bug I created by accident.

Closing

Message #41 received at 72465 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: bjorn.bidar <at> thaodan.de, 72465 <at> debbugs.gnu.org
Subject: Re: bug#72465: Acknowledgement ([PATCH 1/2] Document how set path to C
 source code for SUSE based systems)
Date: Mon, 05 Aug 2024 15:31:03 +0300

> Resent-To: bug-gnu-emacs <at> gnu.org
> Cc: Björn Bidar <bjorn.bidar <at> thaodan.de>,
>  72465-done <at> debbugs.gnu.org
> From: Andrea Corallo <acorallo <at> gnu.org>
> Date: Mon, 05 Aug 2024 05:46:47 -0400
> 
> Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs <at> gnu.org> writes:
> 
> > Sorry I meant to send the patches in a reply to the the cover message.
> > Please close the bug I created by accident.
> 
> Closing

There was no need to close them because I merged them.  Now we need to
make sure the main one was not closed inadvertently as result...

Message #44 received at 72465 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: bjorn.bidar <at> thaodan.de, 72465 <at> debbugs.gnu.org
Subject: Re: bug#72465: Acknowledgement ([PATCH 1/2] Document how set path
 to C source code for SUSE based systems)
Date: Mon, 05 Aug 2024 10:26:00 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Resent-To: bug-gnu-emacs <at> gnu.org
>> Cc: Björn Bidar <bjorn.bidar <at> thaodan.de>,
>>  72465-done <at> debbugs.gnu.org
>> From: Andrea Corallo <acorallo <at> gnu.org>
>> Date: Mon, 05 Aug 2024 05:46:47 -0400
>> 
>> Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text
>> editors" <bug-gnu-emacs <at> gnu.org> writes:
>> 
>> > Sorry I meant to send the patches in a reply to the the cover message.
>> > Please close the bug I created by accident.
>> 
>> Closing
>
> There was no need to close them because I merged them.  Now we need to
> make sure the main one was not closed inadvertently as result...

Yep, sorry I saw they were already merged afterwards. I've already
reopened it so I think should be fine.

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.