GNU bug report logs - #7243
[patch] making md5sum's warnings clearer

Previous Next

Full log

Message #13 received at 7243-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: "Benno Schulenberg" <bensberg <at> justemail.net>
Cc: 7243-done <at> debbugs.gnu.org
Subject: Re: bug#7243: [patch] making md5sum's warnings clearer
Date: Tue, 19 Oct 2010 21:28:31 +0200

Jim Meyering wrote:
> Benno Schulenberg wrote:
>> Two years ago I complained about the untranslatability of the warnings
>> that md5sum prints when it has encountered unexpected things:
>> http://lists.gnu.org/archive/html/bug-coreutils/2008-09/msg00168.html
>>
>> Jim asked to come up with a change that doesn't remove information.
>> I've finally gotten around to making this -- see the attached patch.
>> In addition to read failures and checksum failures, md5sum now alerts
>> the user to the number of misformatted checksum lines.  It prints this
>> line also when '--warn' is not given, because it is so important.
>
> Thanks for following up.
> I've applied your patch after adjusting the log and a failing test,
> then added two more tests to cover the new types of output lines.
>
> Subject: [PATCH 1/2] md5sum: print a summary warning for improperly formatted lines
>
> And remove the now-superfluous totals from the other two warnings,
> so the plurals will also work in other languages than English.
>
> * src/md5sum.c (digest_check): Change as above.
> * tests/misc/md5sum (check-quiet2): Adjust accordingly.

FYI, I'm marking this as closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.