GNU bug report logs - #7242
`read-color' and `facemenu-read-color' redundant-p

Previous Next

Package: emacs;

Reported by: MON KEY <monkey <at> sandpframing.com>

Date: Mon, 18 Oct 2010 18:38:01 UTC

Severity: wishlist

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7242 in the body.
You can then email your comments to 7242 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7242; Package emacs. (Mon, 18 Oct 2010 18:38:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to MON KEY <monkey <at> sandpframing.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 18 Oct 2010 18:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: MON KEY <monkey <at> sandpframing.com>
To: bug-gnu-emacs <at> gnu.org
Subject: `read-color' and `facemenu-read-color' redundant-p
Date: Mon, 18 Oct 2010 14:40:53 -0400

lisp/faces.el defines `read-color'
lisp/facemenu.el defines `facemenu-read-color'.

Is the functionality of the two sufficiently similar that `read-color' can
be used in lieu of `facemenu-read-color'?

If not, maybe the two fncn's should be merged...

--
/s_P\
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7242; Package emacs. (Sun, 24 Oct 2010 18:41:02 GMT) Full text and rfc822 format available.

Message #8 received at 7242 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: MON KEY <monkey <at> sandpframing.com>
Cc: 7242 <at> debbugs.gnu.org
Subject: Re: bug#7242: `read-color' and `facemenu-read-color' redundant-p
Date: Sun, 24 Oct 2010 14:44:12 -0400

MON KEY <monkey <at> sandpframing.com> writes:

> lisp/faces.el defines `read-color'
> lisp/facemenu.el defines `facemenu-read-color'.
>
> Is the functionality of the two sufficiently similar that `read-color' can
> be used in lieu of `facemenu-read-color'?
>
> If not, maybe the two fncn's should be merged...

Yeah, the introduction of read-color seems like an oversight.

I've merged the two functions, and renamed the result into `read-color'.

Thanks.
bug closed, send any further explanations to MON KEY <monkey <at> sandpframing.com> Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Sun, 24 Oct 2010 18:41:02 GMT) Full text and rfc822 format available.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7242; Package emacs. (Sun, 24 Oct 2010 19:45:02 GMT) Full text and rfc822 format available.

Message #13 received at 7242 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Chong Yidong'" <cyd <at> stupidchicken.com>,
	"'MON KEY'" <monkey <at> sandpframing.com>
Cc: 7242 <at> debbugs.gnu.org
Subject: RE: bug#7242: `read-color' and `facemenu-read-color' redundant-p
Date: Sun, 24 Oct 2010 12:46:16 -0700

> Yeah, the introduction of read-color seems like an oversight.
> 
> I've merged the two functions, and renamed the result into 
> `read-color'.

See http://lists.gnu.org/archive/html/emacs-devel/2008-10/msg00474.html.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 22 Nov 2010 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 214 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.