GNU bug report logs - #7243
[patch] making md5sum's warnings clearer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Benno Schulenberg" <bensberg <at> justemail.net>
Subject: bug#7243: closed (Re: bug#7243: [patch] making md5sum's warnings
 clearer)
Date: Tue, 19 Oct 2010 19:25:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#7243: [patch] making md5sum's warnings clearer

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 7243 <at> debbugs.gnu.org.

-- 
7243: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7243
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: "Benno Schulenberg" <bensberg <at> justemail.net>
Cc: 7243-done <at> debbugs.gnu.org
Subject: Re: bug#7243: [patch] making md5sum's warnings clearer
Date: Tue, 19 Oct 2010 21:28:31 +0200

Jim Meyering wrote:
> Benno Schulenberg wrote:
>> Two years ago I complained about the untranslatability of the warnings
>> that md5sum prints when it has encountered unexpected things:
>> http://lists.gnu.org/archive/html/bug-coreutils/2008-09/msg00168.html
>>
>> Jim asked to come up with a change that doesn't remove information.
>> I've finally gotten around to making this -- see the attached patch.
>> In addition to read failures and checksum failures, md5sum now alerts
>> the user to the number of misformatted checksum lines.  It prints this
>> line also when '--warn' is not given, because it is so important.
>
> Thanks for following up.
> I've applied your patch after adjusting the log and a failing test,
> then added two more tests to cover the new types of output lines.
>
> Subject: [PATCH 1/2] md5sum: print a summary warning for improperly formatted lines
>
> And remove the now-superfluous totals from the other two warnings,
> so the plurals will also work in other languages than English.
>
> * src/md5sum.c (digest_check): Change as above.
> * tests/misc/md5sum (check-quiet2): Adjust accordingly.

FYI, I'm marking this as closed.

[Message part 3 (message/rfc822, inline)]

From: "Benno Schulenberg" <bensberg <at> justemail.net>
To: bug-coreutils <at> gnu.org
Subject: [patch] making md5sum's warnings clearer
Date: Mon, 18 Oct 2010 22:51:37 +0200

[Message part 4 (text/plain, inline)]

Hi,

Two years ago I complained about the untranslatability of the warnings
that md5sum prints when it has encountered unexpected things:
http://lists.gnu.org/archive/html/bug-coreutils/2008-09/msg00168.html

Jim asked to come up with a change that doesn't remove information.
I've finally gotten around to making this -- see the attached patch.
In addition to read failures and checksum failures, md5sum now alerts
the user to the number of misformatted checksum lines.  It prints this
line also when '--warn' is not given, because it is so important.

Regards,

Benno

(Please CC, not subscribed.)

-- 
http://www.fastmail.fm - Same, same, but different...

[0001-md5sum-print-a-summary-warning-for-improperly-format.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.