GNU bug report logs - #7242
`read-color' and `facemenu-read-color' redundant-p

Previous Next

Package: emacs;

Reported by: MON KEY <monkey <at> sandpframing.com>

Date: Mon, 18 Oct 2010 18:38:01 UTC

Severity: wishlist

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> stupidchicken.com>
To: MON KEY <monkey <at> sandpframing.com>
Cc: 7242 <at> debbugs.gnu.org
Subject: bug#7242: `read-color' and `facemenu-read-color' redundant-p
Date: Sun, 24 Oct 2010 14:44:12 -0400

MON KEY <monkey <at> sandpframing.com> writes:

> lisp/faces.el defines `read-color'
> lisp/facemenu.el defines `facemenu-read-color'.
>
> Is the functionality of the two sufficiently similar that `read-color' can
> be used in lieu of `facemenu-read-color'?
>
> If not, maybe the two fncn's should be merged...

Yeah, the introduction of read-color seems like an oversight.

I've merged the two functions, and renamed the result into `read-color'.

Thanks.
This bug report was last modified 14 years and 214 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.