GNU bug report logs - #72404
30.0.60; Customization of options is broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72404 in the body.
You can then email your comments to 72404 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.60; Customization of options is broken
Date: Wed, 31 Jul 2024 20:25:30 +0300

I found this bug while testing 'tab-bar-format', but all
customizable variables that use :options are broken in emacs-30.
Here is an example for 'log-edit-hook':

0. emacs-30 -Q
1. Eval: (require 'log-edit)
2. Check the value of 'log-edit-hook'.
   Its value is
   (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
3. M-x customize-variable RET log-edit-hook RET
4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'.
5. Apply
6. Check the value of 'log-edit-hook'.
   Its value is (log-edit-insert-cvs-rcstemplate)

In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit,
 cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31
Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d
Repository branch: emacs-30
Windowing system distributor 'The X.Org Foundation', version 11
Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid'

Whereas in GNU Emacs 29.3.50 it was correctly changed to
(log-edit-insert-message-template log-edit-insert-cvs-rcstemplate
log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)

Message #8 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>, Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 72404 <at> debbugs.gnu.org
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Wed, 31 Jul 2024 21:04:54 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Date: Wed, 31 Jul 2024 20:25:30 +0300
> 
> I found this bug while testing 'tab-bar-format', but all
> customizable variables that use :options are broken in emacs-30.
> Here is an example for 'log-edit-hook':
> 
> 0. emacs-30 -Q
> 1. Eval: (require 'log-edit)
> 2. Check the value of 'log-edit-hook'.
>    Its value is
>    (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
> 3. M-x customize-variable RET log-edit-hook RET
> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'.
> 5. Apply
> 6. Check the value of 'log-edit-hook'.
>    Its value is (log-edit-insert-cvs-rcstemplate)
> 
> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit,
>  cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31
> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d
> Repository branch: emacs-30
> Windowing system distributor 'The X.Org Foundation', version 11
> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid'
> 
> Whereas in GNU Emacs 29.3.50 it was correctly changed to
> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate
> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)

Thanks.  Bisection would be useful, I think.

Adding Mauro, in case he has some ideas or even fixes.

Message #11 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72404 <at> debbugs.gnu.org, stephen.berman <at> gmx.net,
 Mauro Aranda <maurooaranda <at> gmail.com>, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Wed, 31 Jul 2024 15:18:46 -0500

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Juri Linkov <juri <at> linkov.net>
>> Date: Wed, 31 Jul 2024 20:25:30 +0300
>> 
>> I found this bug while testing 'tab-bar-format', but all
>> customizable variables that use :options are broken in emacs-30.
>> Here is an example for 'log-edit-hook':
>> 
>> 0. emacs-30 -Q
>> 1. Eval: (require 'log-edit)
>> 2. Check the value of 'log-edit-hook'.
>>    Its value is
>>    (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
>> 3. M-x customize-variable RET log-edit-hook RET
>> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'.
>> 5. Apply
>> 6. Check the value of 'log-edit-hook'.
>>    Its value is (log-edit-insert-cvs-rcstemplate)
>> 
>> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit,
>>  cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31
>> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d
>> Repository branch: emacs-30
>> Windowing system distributor 'The X.Org Foundation', version 11
>> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid'
>> 
>> Whereas in GNU Emacs 29.3.50 it was correctly changed to
>> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate
>> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
>
> Thanks.  Bisection would be useful, I think.
>
> Adding Mauro, in case he has some ideas or even fixes.

Reverting 8d354925ddb fixes it here.

Message #14 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>, stephen.berman <at> gmx.net
Cc: 72404 <at> debbugs.gnu.org, maurooaranda <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Thu, 01 Aug 2024 08:09:52 +0300

> From: john muhl <jm <at> pub.pink>
> Cc: Juri Linkov <juri <at> linkov.net>,  Mauro Aranda <maurooaranda <at> gmail.com>,
>   72404 <at> debbugs.gnu.org,  stephen.berman <at> gmx.net
> Date: Wed, 31 Jul 2024 15:18:46 -0500
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> 0. emacs-30 -Q
> >> 1. Eval: (require 'log-edit)
> >> 2. Check the value of 'log-edit-hook'.
> >>    Its value is
> >>    (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
> >> 3. M-x customize-variable RET log-edit-hook RET
> >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'.
> >> 5. Apply
> >> 6. Check the value of 'log-edit-hook'.
> >>    Its value is (log-edit-insert-cvs-rcstemplate)
> >> 
> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit,
> >>  cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31
> >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d
> >> Repository branch: emacs-30
> >> Windowing system distributor 'The X.Org Foundation', version 11
> >> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid'
> >> 
> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to
> >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate
> >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
> >
> > Thanks.  Bisection would be useful, I think.
> >
> > Adding Mauro, in case he has some ideas or even fixes.
> 
> Reverting 8d354925ddb fixes it here.

Thanks!

Stephen, please look at this ASAP, as this sounds like a serious
and very recent regression.

Message #17 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72404 <at> debbugs.gnu.org, john muhl <jm <at> pub.pink>, maurooaranda <at> gmail.com,
 juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Thu, 01 Aug 2024 12:12:52 +0200

On Thu, 01 Aug 2024 08:09:52 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: john muhl <jm <at> pub.pink>
>> Cc: Juri Linkov <juri <at> linkov.net>,  Mauro Aranda <maurooaranda <at> gmail.com>,
>>   72404 <at> debbugs.gnu.org,  stephen.berman <at> gmx.net
>> Date: Wed, 31 Jul 2024 15:18:46 -0500
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> 0. emacs-30 -Q
>> >> 1. Eval: (require 'log-edit)
>> >> 2. Check the value of 'log-edit-hook'.
>> >>    Its value is
>> >>    (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
>> >> 3. M-x customize-variable RET log-edit-hook RET
>> >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'.
>> >> 5. Apply
>> >> 6. Check the value of 'log-edit-hook'.
>> >>    Its value is (log-edit-insert-cvs-rcstemplate)
>> >>
>> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit,
>> >>  cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31
>> >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d
>> >> Repository branch: emacs-30
>> >> Windowing system distributor 'The X.Org Foundation', version 11
>> >> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid'
>> >>
>> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to
>> >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate
>> >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
>> >
>> > Thanks.  Bisection would be useful, I think.
>> >
>> > Adding Mauro, in case he has some ideas or even fixes.
>>
>> Reverting 8d354925ddb fixes it here.
>
> Thanks!
>
> Stephen, please look at this ASAP, as this sounds like a serious
> and very recent regression.

I took a look and tried stepping through with Edebug, but so far could
not find out how my changes in that commit cause the regression.  I
won't have time for further debugging until next week, and given my
unfamiliarty with the widget and custom code (I didn't even know about
:options till now), I may well not be able to fix this.  Feel free to
revert the commit in the mean time.  It would also be good to have a
test for this case (in emacs-30 with the commit all widget and custom
tests pass).

Steve Berman

Message #20 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72404 <at> debbugs.gnu.org, john muhl <jm <at> pub.pink>, maurooaranda <at> gmail.com,
 juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Thu, 01 Aug 2024 19:28:04 +0200

On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman <stephen.berman <at> gmx.net> wrote:

> On Thu, 01 Aug 2024 08:09:52 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>>> From: john muhl <jm <at> pub.pink>
>>> Cc: Juri Linkov <juri <at> linkov.net>,  Mauro Aranda <maurooaranda <at> gmail.com>,
>>>   72404 <at> debbugs.gnu.org,  stephen.berman <at> gmx.net
>>> Date: Wed, 31 Jul 2024 15:18:46 -0500
>>>
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>
>>> >> 0. emacs-30 -Q
>>> >> 1. Eval: (require 'log-edit)
>>> >> 2. Check the value of 'log-edit-hook'.
>>> >>    Its value is
>>> >>    (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
>>> >> 3. M-x customize-variable RET log-edit-hook RET
>>> >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'.
>>> >> 5. Apply
>>> >> 6. Check the value of 'log-edit-hook'.
>>> >>    Its value is (log-edit-insert-cvs-rcstemplate)
>>> >>
>>> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit,
>>> >>  cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31
>>> >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d
>>> >> Repository branch: emacs-30
>>> >> Windowing system distributor 'The X.Org Foundation', version 11
>>> >> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid'
>>> >>
>>> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to
>>> >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate
>>> >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files)
>>> >
>>> > Thanks.  Bisection would be useful, I think.
>>> >
>>> > Adding Mauro, in case he has some ideas or even fixes.
>>>
>>> Reverting 8d354925ddb fixes it here.
>>
>> Thanks!
>>
>> Stephen, please look at this ASAP, as this sounds like a serious
>> and very recent regression.
>
> I took a look and tried stepping through with Edebug, but so far could
> not find out how my changes in that commit cause the regression.  I
> won't have time for further debugging until next week, and given my
> unfamiliarty with the widget and custom code (I didn't even know about
> :options till now), I may well not be able to fix this.  Feel free to
> revert the commit in the mean time.  It would also be good to have a
> test for this case (in emacs-30 with the commit all widget and custom
> tests pass).

I did happen to have a bit more time for this problem, and I think I've
found the cause, a single line in commit 8d354925ddb:

diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index 693991a6f3e..aa653549dad 100644
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -2549,7 +2549,8 @@ widget-checklist-add-item
 			    (t
 			     (widget-create-child-value
 			      widget type (car (cdr chosen)))
-                             (widget-specify-selected child)))))
+                             ;; (widget-specify-selected child)
+                             ))))
 	       (t
 		(error "Unknown escape `%c'" escape)))))
      ;; Update properties.

With this line commented out as in the above patch, I get the expected
value when carrying out Juri's recipe.  Moreover, after making that
change, I then briefly tested customizing the face widget-unselected
(which the problematic commit added) to inherit from the default face
and it shows the labels of unselected check boxes in the default face,
as it should.  So maybe deleting the commented out line above and
leaving the rest of the change is a sufficient fix.  But I have to admit
I don't know why that line causes the problem, and I haven't done enough
testing of this change to the widget-unselected face feature, so this is
just a status report.

Steve Berman

Message #25 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 72404 <at> debbugs.gnu.org, jm <at> pub.pink, maurooaranda <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Sun, 04 Aug 2024 10:49:52 +0300

> From: Stephen Berman <stephen.berman <at> gmx.net>
> Cc: john muhl <jm <at> pub.pink>,  juri <at> linkov.net,  maurooaranda <at> gmail.com,
>   72404 <at> debbugs.gnu.org
> Date: Thu, 01 Aug 2024 19:28:04 +0200
> 
> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman <stephen.berman <at> gmx.net> wrote:
> 
> I did happen to have a bit more time for this problem, and I think I've
> found the cause, a single line in commit 8d354925ddb:
> 
> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
> index 693991a6f3e..aa653549dad 100644
> --- a/lisp/wid-edit.el
> +++ b/lisp/wid-edit.el
> @@ -2549,7 +2549,8 @@ widget-checklist-add-item
>  			    (t
>  			     (widget-create-child-value
>  			      widget type (car (cdr chosen)))
> -                             (widget-specify-selected child)))))
> +                             ;; (widget-specify-selected child)
> +                             ))))
>  	       (t
>  		(error "Unknown escape `%c'" escape)))))
>       ;; Update properties.
> 
> With this line commented out as in the above patch, I get the expected
> value when carrying out Juri's recipe.  Moreover, after making that
> change, I then briefly tested customizing the face widget-unselected
> (which the problematic commit added) to inherit from the default face
> and it shows the labels of unselected check boxes in the default face,
> as it should.  So maybe deleting the commented out line above and
> leaving the rest of the change is a sufficient fix.  But I have to admit
> I don't know why that line causes the problem, and I haven't done enough
> testing of this change to the widget-unselected face feature, so this is
> just a status report.

Thanks, I installed the above fix.

It turns out the same problem also caused bug#72156, so I've now
merged them.

I'm leaving this bug open, in the hope that you or someone else will
find the root cause for the regression and fix it.

Message #28 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72404 <at> debbugs.gnu.org, jm <at> pub.pink, maurooaranda <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Sun, 04 Aug 2024 12:00:23 +0200

On Sun, 04 Aug 2024 10:49:52 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: Stephen Berman <stephen.berman <at> gmx.net>
>> Cc: john muhl <jm <at> pub.pink>,  juri <at> linkov.net,  maurooaranda <at> gmail.com,
>>   72404 <at> debbugs.gnu.org
>> Date: Thu, 01 Aug 2024 19:28:04 +0200
>>
>> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman <stephen.berman <at> gmx.net> wrote:
>>
>> I did happen to have a bit more time for this problem, and I think I've
>> found the cause, a single line in commit 8d354925ddb:
>>
>> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
>> index 693991a6f3e..aa653549dad 100644
>> --- a/lisp/wid-edit.el
>> +++ b/lisp/wid-edit.el
>> @@ -2549,7 +2549,8 @@ widget-checklist-add-item
>>  			    (t
>>  			     (widget-create-child-value
>>  			      widget type (car (cdr chosen)))
>> -                             (widget-specify-selected child)))))
>> +                             ;; (widget-specify-selected child)
>> +                             ))))
>>  	       (t
>>  		(error "Unknown escape `%c'" escape)))))
>>       ;; Update properties.
>>
>> With this line commented out as in the above patch, I get the expected
>> value when carrying out Juri's recipe.  Moreover, after making that
>> change, I then briefly tested customizing the face widget-unselected
>> (which the problematic commit added) to inherit from the default face
>> and it shows the labels of unselected check boxes in the default face,
>> as it should.  So maybe deleting the commented out line above and
>> leaving the rest of the change is a sufficient fix.  But I have to admit
>> I don't know why that line causes the problem, and I haven't done enough
>> testing of this change to the widget-unselected face feature, so this is
>> just a status report.
>
> Thanks, I installed the above fix.

Thanks, this seems at least a plausible stopgap.

> It turns out the same problem also caused bug#72156, so I've now
> merged them.
>
> I'm leaving this bug open, in the hope that you or someone else will
> find the root cause for the regression and fix it.

I will try to debug it further, but I do hope Mauro or someone else more
familiar with the widget and custom code than I am will look into it.

Steve Berman

Message #31 received at 72404 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 72404 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Stephen Berman <stephen.berman <at> gmx.net>,
 jm <at> pub.pink, juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Wed, 1 Jan 2025 08:31:14 -0300

[Message part 1 (text/plain, inline)]

Stephen Berman <stephen.berman <at> gmx.net> writes:

> On Sun, 04 Aug 2024 10:49:52 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>>> From: Stephen Berman <stephen.berman <at> gmx.net>
>>> Cc: john muhl <jm <at> pub.pink>, juri <at> linkov.net,  maurooaranda <at> gmail.com,
>>>   72404 <at> debbugs.gnu.org
>>> Date: Thu, 01 Aug 2024 19:28:04 +0200
>>>
>>> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman 
<stephen.berman <at> gmx.net> wrote:
>>>
>>> I did happen to have a bit more time for this problem, and I think I've
>>> found the cause, a single line in commit 8d354925ddb:
>>>
>>> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
>>> index 693991a6f3e..aa653549dad 100644
>>> --- a/lisp/wid-edit.el
>>> +++ b/lisp/wid-edit.el
>>> @@ -2549,7 +2549,8 @@ widget-checklist-add-item
>>>                  (t
>>>                   (widget-create-child-value
>>>                    widget type (car (cdr chosen)))
>>> - (widget-specify-selected child)))))
>>> +                             ;; (widget-specify-selected child)
>>> +                             ))))
>>>             (t
>>>          (error "Unknown escape `%c'" escape)))))
>>>       ;; Update properties.
>>>
>>> With this line commented out as in the above patch, I get the expected
>>> value when carrying out Juri's recipe.  Moreover, after making that
>>> change, I then briefly tested customizing the face widget-unselected
>>> (which the problematic commit added) to inherit from the default face
>>> and it shows the labels of unselected check boxes in the default face,
>>> as it should.  So maybe deleting the commented out line above and
>>> leaving the rest of the change is a sufficient fix.  But I have to 
admit
>>> I don't know why that line causes the problem, and I haven't done 
enough
>>> testing of this change to the widget-unselected face feature, so 
this is
>>> just a status report.
>>
>> Thanks, I installed the above fix.
>
> Thanks, this seems at least a plausible stopgap.
>
>> It turns out the same problem also caused bug#72156, so I've now
>> merged them.
>>
>> I'm leaving this bug open, in the hope that you or someone else will
>> find the root cause for the regression and fix it.
>
> I will try to debug it further, but I do hope Mauro or someone else more
> familiar with the widget and custom code than I am will look into it.
>
> Steve Berman

Looks to me that it's a matter of order of function calls.  The return
value of widget-create-child-value was used for setting child.

I found this by using widget-browse-at at the checkbox.  I navigated to
the checkbox parent, the set widget, and saw that only the unselected
children were specified as children of the set widget.

The attached patch should fix it.

[0001-Fix-checkbox-s-child-creation.patch (text/x-patch, attachment)]

Message #36 received at 72404-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 72404-done <at> debbugs.gnu.org, stephen.berman <at> gmx.net, jm <at> pub.pink,
 juri <at> linkov.net
Subject: Re: bug#72404: 30.0.60; Customization of options is broken
Date: Sat, 11 Jan 2025 13:57:18 +0200

> Date: Wed, 1 Jan 2025 08:31:14 -0300
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Stephen Berman <stephen.berman <at> gmx.net>,
>  jm <at> pub.pink, juri <at> linkov.net
> From: Mauro Aranda <maurooaranda <at> gmail.com>
> 
> Looks to me that it's a matter of order of function calls.  The return
> value of widget-create-child-value was used for setting child.
> 
> I found this by using widget-browse-at at the checkbox.  I navigated to
> the checkbox parent, the set widget, and saw that only the unselected
> children were specified as children of the set widget.
> 
> The attached patch should fix it.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.